From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Naman Gulati <namangulati@google.com>,
Coco Li <lixiaoyan@google.com>, Wei Wang <weiwan@google.com>,
eric.dumazet@gmail.com
Subject: Re: [PATCH net 3/3] net-device: move lstats in net_device_read_txrx
Date: Fri, 9 Feb 2024 17:15:53 +0000 [thread overview]
Message-ID: <20240209171553.GE1533412@kernel.org> (raw)
In-Reply-To: <20240208144323.1248887-4-edumazet@google.com>
On Thu, Feb 08, 2024 at 02:43:23PM +0000, Eric Dumazet wrote:
> dev->lstats is notably used from loopback ndo_start_xmit()
> and other virtual drivers.
>
> Per cpu stats updates are dirtying per-cpu data,
> but the pointer itself is read-only.
>
> Fixes: 43a71cd66b9c ("net-device: reorganize net_device fast path variables")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Coco Li <lixiaoyan@google.com>
> Cc: Simon Horman <horms@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-09 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 14:43 [PATCH net 0/3] net: more three misplaced fields Eric Dumazet
2024-02-08 14:43 ` [PATCH net 1/3] tcp: move tp->scaling_ratio to tcp_sock_read_txrx group Eric Dumazet
2024-02-09 17:15 ` Simon Horman
2024-02-08 14:43 ` [PATCH net 2/3] tcp: move tp->tcp_usec_ts " Eric Dumazet
2024-02-09 17:15 ` Simon Horman
2024-02-08 14:43 ` [PATCH net 3/3] net-device: move lstats in net_device_read_txrx Eric Dumazet
2024-02-09 17:15 ` Simon Horman [this message]
2024-02-12 10:00 ` [PATCH net 0/3] net: more three misplaced fields patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209171553.GE1533412@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=lixiaoyan@google.com \
--cc=namangulati@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).