From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 276AF7BAF4 for ; Fri, 9 Feb 2024 17:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707498958; cv=none; b=krlatVi5KaE15wPTfv/iQJ2N2dIioieMBDb6jko6LNCIzxOthPA5+X0BXG6u1aSCMiKtcTt2KeBgWqr0P7KVtvCRUCDNuf2n+z2qz3pnJQ0IpU0RFxZkirseVy9fo7h9ccDt6JKOdBZe7YcLPNNMKbe6wU9gMFRAW0IfkkhjA4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707498958; c=relaxed/simple; bh=nfyUo80qI42Kcan7DmQ6iEXtdTmcAtNUkBQEY7xI2Vg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qB6l1Q865ZUt5LsqL+6N5ReNUMPi7yDc0Nzo4fPlaJDB+sJzCy9nRMhl2Vg6zaVwhrxD8D7EMYMYat64hT/0NGycq4TaFunc60h9+yupBTlrBIz7Hdga/Zy8jW/2r4wZQk2Lccg27itOgTxWiyQ1lNsuayrOzAEk5K2P5oH0+co= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JFZ9nEEa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JFZ9nEEa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDE0CC433C7; Fri, 9 Feb 2024 17:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707498957; bh=nfyUo80qI42Kcan7DmQ6iEXtdTmcAtNUkBQEY7xI2Vg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JFZ9nEEa7/vc3DgDI7gGEPMvxf6uRPwb6I3veepiuIjuIJs5soHpeZh1DzI+ERHWw fsPOqWq1wNsGQyCfAEyDY6+9RWO9Bnwco/D+GD7I9zlYj6me2/hFIqSAFoLxMWGFoA uSBQ4h5SPmRjoQfTtNpTQg/WBVmYrsr1xpTfTr1i8I2dcwiCoGtA1W0dxeZm1+8ZVz sP9iLzcXqcOy9AgyoLxrVJcgwrQR0w7wAHaKXTElsjUdG5ZUeZlxTIHM1GvE+aLqvo TX98gUw5rolrE5BRRIxYV2W7yerfR3UwSkjTtTvHguI4gmRekYm13cBzWU/F8XKT1u xT4uCqTpoK/7w== Date: Fri, 9 Feb 2024 17:15:53 +0000 From: Simon Horman To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Naman Gulati , Coco Li , Wei Wang , eric.dumazet@gmail.com Subject: Re: [PATCH net 3/3] net-device: move lstats in net_device_read_txrx Message-ID: <20240209171553.GE1533412@kernel.org> References: <20240208144323.1248887-1-edumazet@google.com> <20240208144323.1248887-4-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208144323.1248887-4-edumazet@google.com> On Thu, Feb 08, 2024 at 02:43:23PM +0000, Eric Dumazet wrote: > dev->lstats is notably used from loopback ndo_start_xmit() > and other virtual drivers. > > Per cpu stats updates are dirtying per-cpu data, > but the pointer itself is read-only. > > Fixes: 43a71cd66b9c ("net-device: reorganize net_device fast path variables") > Signed-off-by: Eric Dumazet > Cc: Coco Li > Cc: Simon Horman Reviewed-by: Simon Horman