From: Jakub Kicinski <kuba@kernel.org>
To: Sasha Neftin <sasha.neftin@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, Paul Menzel <pmenzel@molgen.mpg.de>,
Naama Meir <naamax.meir@linux.intel.com>,
"Ruinskiy, Dima" <dima.ruinskiy@intel.com>
Subject: Re: [PATCH net 2/2] igc: Remove temporary workaround
Date: Mon, 12 Feb 2024 09:08:46 -0800 [thread overview]
Message-ID: <20240212090846.18c517fc@kernel.org> (raw)
In-Reply-To: <ce4065d5-656d-4554-b288-94105a3631cc@intel.com>
On Sun, 11 Feb 2024 08:53:36 +0200 Sasha Neftin wrote:
> > Any more info on this one?
> > What's the user impact?
> > What changed (e.g. which FW version fixed it)?
>
> User impact: PHY could be powered down when the link is down (ip link
> set down <device>)
to make it a tiny bit clearer:
s/could/can now/ ?
s/link is down/device is down/ ?
> Fix by PHY firmware and deployed via OEM updates (automatically, with
> OEM SW/FW updates). We checked the IEEE behavior and removed w/a.
>
> The PHY vendor no longer works with Intel, but I can say this was fixed
> on a very early silicon step (years ago).
And the versions of the PHY components are not easily accessible so we
can't point to the version that was buggy or at least the oldest you
tested? If that's the case - it is what it is, please repost with the
improved commit msg.
next prev parent reply other threads:[~2024-02-12 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 21:28 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2024-02-06 (igb, igc) Tony Nguyen
2024-02-06 21:28 ` [PATCH net 1/2] igb: Fix string truncation warnings in igb_set_fw_version Tony Nguyen
2024-02-06 21:28 ` [PATCH net 2/2] igc: Remove temporary workaround Tony Nguyen
2024-02-09 2:33 ` Jakub Kicinski
2024-02-11 6:53 ` Sasha Neftin
2024-02-12 17:08 ` Jakub Kicinski [this message]
2024-02-13 12:12 ` Sasha Neftin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212090846.18c517fc@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).