From: Jakub Kicinski <kuba@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Qian Cai <quic_qiancai@quicinc.com>,
mptcp@lists.linux.dev, netdev@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] configs/debug: add NET debug config
Date: Mon, 12 Feb 2024 17:02:53 -0800 [thread overview]
Message-ID: <20240212170253.77a7be7c@kernel.org> (raw)
In-Reply-To: <202402121039.E14DF37@keescook>
On Mon, 12 Feb 2024 10:39:55 -0800 Kees Cook wrote:
> > Notes:
> > - It looks like this debug.config doesn't have a specific maintainer.
> > If this patch is not rejected, I don't know if this modification can
> > go through the net tree, or if it should be handled by Andrew.
> > Probably the latter? I didn't add [net-next] in the subject for this
> > reason.
>
> Adding these seem reasonable. I touched debug.config last, so I can take
> it via the kernel hardening tree if netdev doesn't want to take it.
I'd prefer to have it in net-next sooner rather than later, because
when our CI hits an issue we can tell people:
make defconfig debug.config
make
otherwise I have to explain what options to twiddle with. And the
refcount options do catch bugs, I had to do this exact the explaining
last Friday :(
So I'd offer these three options:
- we put it on a shared branch and both pull in
- you send to Linus within a week and we'll get it soon that way
- we take it to net-next directly
What's your preference?
next prev parent reply other threads:[~2024-02-13 1:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 10:47 [PATCH] configs/debug: add NET debug config Matthieu Baerts (NGI0)
2024-02-12 18:39 ` Kees Cook
2024-02-13 1:02 ` Jakub Kicinski [this message]
2024-02-13 1:27 ` Andrew Morton
2024-02-13 1:52 ` Kees Cook
2024-02-16 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212170253.77a7be7c@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_qiancai@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).