netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: Jiri Pirko <jiri@resnulli.us>,
	Sabrina Dubroca <sd@queasysnail.net>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v10 3/3] netdevsim: add selftest for forwarding skb between connected ports
Date: Tue, 13 Feb 2024 06:06:22 -0800	[thread overview]
Message-ID: <20240213060622.33593442@kernel.org> (raw)
In-Reply-To: <20240212220544.70546-4-dw@davidwei.uk>

On Mon, 12 Feb 2024 14:05:44 -0800 David Wei wrote:
> +	ip netns add nssv
> +	ip netns add nscl

You're missing a

	udevadm settle

somewhere between creating the devices and getting their names.
Otherwise they'll get auto-renamed while the test is running.

> +	NSIM_DEV_1_NAME=$(find $NSIM_DEV_1_SYS/net -maxdepth 1 -type d ! \
> +		-path $NSIM_DEV_1_SYS/net -exec basename {} \;)
> +	NSIM_DEV_2_NAME=$(find $NSIM_DEV_2_SYS/net -maxdepth 1 -type d ! \
> +		-path $NSIM_DEV_2_SYS/net -exec basename {} \;)
-- 
pw-bot: cr

      reply	other threads:[~2024-02-13 14:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 22:05 [PATCH net-next v10 0/3] netdevsim: link and forward skbs between ports David Wei
2024-02-12 22:05 ` [PATCH net-next v10 1/3] netdevsim: allow two netdevsim ports to be connected David Wei
2024-02-12 22:05 ` [PATCH net-next v10 2/3] netdevsim: forward skbs from one connected port to another David Wei
2024-02-12 22:05 ` [PATCH net-next v10 3/3] netdevsim: add selftest for forwarding skb between connected ports David Wei
2024-02-13 14:06   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213060622.33593442@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dw@davidwei.uk \
    --cc=edumazet@google.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).