From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54FEF60ECD for ; Tue, 13 Feb 2024 17:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707846891; cv=none; b=R7KHKrxLmRfYzdmCV5oQ2+8o/AIj1dnQtaJu56Xjh1A2L1RAOJgHuKr0J60/01V5mcumDMIgg8NSEmQ0JVSCpfJHg3iaYS9LbABdf/E3iUJK7MY1bSB9wjJyWAuUWsBPMpbJ5qAho3b8ve//3G72keHn2Hw9P/erpsNvxAGLT6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707846891; c=relaxed/simple; bh=ltk1jYeKwRUauD0F89EDsQOKWDQ5iIs7WuWPDIBxPEM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DyPSQnc0jpWlJ3iEvDXIKtC90p/Idr8wopZORSfOL9iqRhUcDYu22XtSBnl/8bG3YrnA2NIGrHcfqnWDzQMMldIDA0VUGiJNFz5oToZd2RMwpn9FOuaNOrOnbn230EYDG6QuovKka1nfYgf3A5VWj3BQHcivPbS0C8hBDg19uJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=TfaecKkZ; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TfaecKkZ" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d94323d547so40704735ad.3 for ; Tue, 13 Feb 2024 09:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707846889; x=1708451689; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LVxF0kPBBK4a5u/pCNXJRf9fK1X9kNc5Ul9aamHPDYM=; b=TfaecKkZ3hMdh2yYAEX0i24XSqQCMYgaKVXZaKRZXyedpr0PlXiCEUKBqMcc+IXM01 7lFiGPHvFDEl21WmXk7KH2Z98kxoPDh88ekNLTinf2DxNN1cxTVSgvqJ5k/iTAZnixjr wv9B9hXXnRZcZqa08gv/7fFLEzyTR1pHzZOao= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707846889; x=1708451689; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LVxF0kPBBK4a5u/pCNXJRf9fK1X9kNc5Ul9aamHPDYM=; b=Qxe2am3CwGS1PUMtQjf/zDyP/9S14//UxNsCNMp/KaAkM23PvycAfe9x1Os3CWTRb/ fdM6PItVxpeqi7aTRMk3UGxkdXN1PApEdFCq8Un8pyEU+9DmJqu0qFsINSa3oHmYGSpU +NNFgXMyOZd+Axf9MVAtFYyrtR6CVFjVBCKWu3FbErb5TmpAWG+rPA0v9GXuFl8wn9T+ lm4+qI0EvcgMtxf7/BIam/DJZw/FBEn4/K0dq/7YFo6VdwEBhZkXmTF4ngKt52JEEgwL Eev8wg37uF9Ta2mMbr+iEe8D3tuoC7fWsjZEyOfprpcbJoNPhVA8T2O3lR1/h991twRY AoEQ== X-Forwarded-Encrypted: i=1; AJvYcCVczjgvYi3zFOs/hq/oJT049bFh6w9LLGx8zMnRVicWR7KsQscX1Qol+JHV/k5SPS1isNOqmXgxz/5e2Cx3+ht5QGJe9kw9 X-Gm-Message-State: AOJu0YzVp8l/u9XmyRDudMecM8Ykxj1YDNBPzyJ7XdzMtWCNVKX5XvXk I/gVE7a2bDeSFOY+dhwKYGxb/Sd0hELY7Wvez5BlJLUviEYgQyZQNcjYxlGtCvPPvDbBITDcXjU = X-Google-Smtp-Source: AGHT+IHbSSe09lc2goe7Zz2nMO0NQD3yTUJSyzKOLScRX9ZNW7ki3TOsn4UQUDiuRXXoGz2jGzoH6Q== X-Received: by 2002:a17:902:e5d1:b0:1da:2128:eb16 with SMTP id u17-20020a170902e5d100b001da2128eb16mr336068plf.3.1707846889662; Tue, 13 Feb 2024 09:54:49 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUEqoqd7vHyvsliRvzqnInF2fkakT543gYVgWUreedEgCy2opQ3LnqtU3XM231EKtLGAS4GjEBVHBBWKUpkkKeoB3ld9eAmLGFOoJ0H1w2EwNRZJJJU1akbWHCoeK1fWfu2jtJ75YPciLJis9A7dN+4YL6PcJ0fPfZiLx0zlg== Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id mp13-20020a170902fd0d00b001db3bffd1a8sm1371545plb.42.2024.02.13.09.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 09:54:49 -0800 (PST) Date: Tue, 13 Feb 2024 09:54:48 -0800 From: Kees Cook To: Jakub Kicinski Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, jakub@cloudflare.com Subject: Re: [PATCH net-next 1/4] selftests: kselftest_harness: pass step via shared memory Message-ID: <202402130954.108CC0FD52@keescook> References: <20240213154416.422739-1-kuba@kernel.org> <20240213154416.422739-2-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213154416.422739-2-kuba@kernel.org> On Tue, Feb 13, 2024 at 07:44:13AM -0800, Jakub Kicinski wrote: > Commit 0ef67a888375 ("selftests/harness: Report skip reason") > added shared memory to communicate between harness and test. > Use that instead of exit codes to send the failing step back > to the harness. The exit codes are limited and because of > the step passing we can't use the full range of KSFT_* exit > codes. > > Signed-off-by: Jakub Kicinski Ah, very nice! Good idea. Acked-by: Kees Cook -- Kees Cook