From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A882360DE1 for ; Tue, 13 Feb 2024 18:00:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707847204; cv=none; b=CdRyDRov2DXNTDMfTHLCSBau62xWCTWWpzlLeNTrsePXCkNndwJ1wcDO/7NVGAVkRIDgFU2XOuFm+5lss+m5cKC+xguSODtXPfRv1wjWakIZkxfF7SaC16STD6S1ZtmPqoZ30TYfOP/aOm7WpNx48S+NjHeSI/IOcS1p1v4BiUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707847204; c=relaxed/simple; bh=TvjXDcsy5GxF/6E70d0MCgCzpnXHT2Si5PtFYjTrNA0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nlmsHSlASD93Vj5kEqD/qo8C2aVYblDGQKZ+yXxt+FFMcNLDYq2a6bGDzYuBk6tJJ6PSgmzVDJMRqhcT4rvZmV4fOfCf4J6ZN09mjCOnKfJmpgXCgPQQvZu7rBlBxpwVbBafsarbmY5QFLJbuYGiG6UPi7fwhyDA+jeqbD/Tj5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nWT/RMDq; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nWT/RMDq" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6e0f4e3bc59so980583b3a.0 for ; Tue, 13 Feb 2024 10:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707847202; x=1708452002; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fxPirAQpavIzKv9fMWeC7xfOqcl8Yk4GSCo6Uvejoss=; b=nWT/RMDq/JtrvTEFQ0SLbkQYiXO2QjKChZWsKosCG4hJCrRHtitOevB0a4Kp4msBxl IITMlJWg9FyjiPdkjYuxAcEZAj5g52DmJ7dTaOwrphttIb9e+hjumBNxEhygBPSJILTL EUTThuzU9L0E3R20s+AA6GqaGFhWtA0UCuikw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707847202; x=1708452002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fxPirAQpavIzKv9fMWeC7xfOqcl8Yk4GSCo6Uvejoss=; b=nTll9F71tcsP+4HCb9Piq6iKkOYR8FVsFJTiG7n+dzuHUkMMoH9IgUMQYw7rilPr4R dDqB+U3brr7/Xy8KV1XwCkTXyaTu1ie9zJIeZDXuu6LFCNfgjOYJHkmmAwwzxdC7aDLC DFPkyBrEYkyvDkYhYM57DTKO+dv3OAWIriZtzur0B+UWThqnA5PEBm11EJ1/8BA79ZsL frV4l4zIV6UcPyqdb6h7UsF3Mfg3H/+TQgrrJEYxIybbW5pd6gMBEjhZ5pn/922tb9lK X0OBuCpAw109nyE1IoBgnVHrAag27RW4CTaLotQDE/ozw2z8V1k6Lh63CfT3Jj5NSXET AW1g== X-Forwarded-Encrypted: i=1; AJvYcCWFR892/MA0z5vDetdVEmmmZ6+nIgb+nJGZuIKci5K6TVUqZx2zrAQb1g9HgQPwKAYDEP7rZZ+36LIR8Q6DDFnBGF1TSnfp X-Gm-Message-State: AOJu0Yzx7TJ5+4Bev7L3ttlVvB7JhWkAaWLRu0SxmYNxbB5KdXo6kmPY nmOB0phr9KFsNJElvIXBdaFHYNgc48ZkJ94GAZtUMtNqBuN92Th5hzGi27H1s3x6rGNYVcKBhhI = X-Google-Smtp-Source: AGHT+IFnLU6I8dy6/mzsr4+w4iyvfY9n9S0mJzAYlStLSt5gXorOs8zcMVnC8H1qz5TR58WkeVd6fA== X-Received: by 2002:a05:6a21:3183:b0:19c:ad6b:e1c2 with SMTP id za3-20020a056a21318300b0019cad6be1c2mr397959pzb.12.1707847202072; Tue, 13 Feb 2024 10:00:02 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW5tRAPQjI3pcLl22D2Bu0sVo+xfg5ZiS9c2TWVZRy92+lZ2xiOSFl9jDvtsNeF3x+q7ElO8Q+DJeHOOB+vtK+bmi7Z/vnIYMoWo8vXgaHgc3SSn7+lTqI5aeKniRi6dQ/Ic54kc2JqEgC9ywlYyvpo+9BDx3Kr7pDhs2vNaw== Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id y189-20020a62cec6000000b006e0d1e6036bsm5280122pfg.129.2024.02.13.10.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 10:00:01 -0800 (PST) Date: Tue, 13 Feb 2024 10:00:01 -0800 From: Kees Cook To: Jakub Kicinski Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, jakub@cloudflare.com Subject: Re: [PATCH net-next 0/4] selftests: kselftest_harness: support using xfail Message-ID: <202402130957.7B88284338@keescook> References: <20240213154416.422739-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213154416.422739-1-kuba@kernel.org> On Tue, Feb 13, 2024 at 07:44:12AM -0800, Jakub Kicinski wrote: > Hi! > > When running selftests for our subsystem in our CI we'd like all > tests to pass. Currently some tests use SKIP for cases they > expect to fail, because the kselftest_harness limits the return > codes to pass/fail/skip. > > Clean up and support the use of the full range of ksft exit codes > under kselftest_harness. > > To avoid conflicts and get the functionality into the networking > tree ASAP I'd like to put the patches on shared branch so that > both linux-kselftest and net-next can pull it in. Shuah, please > LMK if that'd work for you, and if so which -rc should I base > the branch on. Or is merging directly into net-next okay? I would use XFAIL for seccomp selftests too, but I can wait for the next release. i.e. I don't need a shared branch -- it'd be fine in net-next. But I defer to Shuah as far as the selftest tree is concerned. (FWIW, I don't see any current conflicts.) -- Kees Cook