From: Jason Xing <kerneljasonxing@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org, kuniyu@amazon.com
Cc: netdev@vger.kernel.org, kerneljasonxing@gmail.com,
Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next v4 6/6] tcp: get rid of NOT_SEPCIFIED reason in tcp_v4/6_do_rcv
Date: Tue, 13 Feb 2024 22:05:08 +0800 [thread overview]
Message-ID: <20240213140508.10878-7-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240213140508.10878-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
Finally we can drop this obscure reason in receive path because
we replaced with many other more accurate reasons before.
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
net/ipv4/tcp_ipv4.c | 1 -
net/ipv6/tcp_ipv6.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index c886c671fae9..82e63f6af34b 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1907,7 +1907,6 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
return 0;
}
- reason = SKB_DROP_REASON_NOT_SPECIFIED;
if (tcp_checksum_complete(skb))
goto csum_err;
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 73fef436dbf6..29a0fe0c8101 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1623,7 +1623,6 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
if (np->rxopt.all)
opt_skb = skb_clone_and_charge_r(skb, sk);
- reason = SKB_DROP_REASON_NOT_SPECIFIED;
if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */
struct dst_entry *dst;
--
2.37.3
next prev parent reply other threads:[~2024-02-13 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 14:05 [PATCH net-next v4 0/6] introduce dropreasons in tcp receive path Jason Xing
2024-02-13 14:05 ` [PATCH net-next v4 1/6] tcp: introduce another three dropreasons in " Jason Xing
2024-02-13 15:49 ` David Ahern
2024-02-13 17:00 ` Jason Xing
2024-02-13 14:05 ` [PATCH net-next v4 2/6] tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process() Jason Xing
2024-02-13 14:05 ` [PATCH net-next v4 3/6] tcp: add dropreasons in tcp_rcv_state_process() Jason Xing
2024-02-13 14:05 ` [PATCH net-next v4 4/6] tcp: make the dropreason really work when calling tcp_rcv_state_process() Jason Xing
2024-02-13 14:05 ` [PATCH net-next v4 5/6] tcp: make dropreason in tcp_child_process() work Jason Xing
2024-02-13 14:05 ` Jason Xing [this message]
2024-02-14 2:23 ` [PATCH net-next v4 0/6] introduce dropreasons in tcp receive path Jakub Kicinski
2024-02-14 12:38 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213140508.10878-7-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).