From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
hawk@kernel.org, ilias.apalodimas@linaro.org
Subject: Re: [PATCH net-next] net: page_pool: make page_pool_create inline
Date: Wed, 14 Feb 2024 10:14:50 -0800 [thread overview]
Message-ID: <20240214101450.25ee7e5d@kernel.org> (raw)
In-Reply-To: <499bc85ca1d96ec1f7daff6b7df4350dc50e9256.1707931443.git.lorenzo@kernel.org>
On Wed, 14 Feb 2024 19:01:28 +0100 Lorenzo Bianconi wrote:
> Make page_pool_create utility routine inline a remove exported symbol.
But why? If you add the kdoc back the LoC saved will be 1.
> include/net/page_pool/types.h | 6 +++++-
> net/core/page_pool.c | 10 ----------
> 2 files changed, 5 insertions(+), 11 deletions(-)
No strong opinion, but if you want to do it please put the helper
in helpers.h Let's keep the static inlines clearly separated.
next prev parent reply other threads:[~2024-02-14 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 18:01 [PATCH net-next] net: page_pool: make page_pool_create inline Lorenzo Bianconi
2024-02-14 18:14 ` Jakub Kicinski [this message]
2024-02-14 19:14 ` Lorenzo Bianconi
2024-03-01 10:27 ` Ilias Apalodimas
2024-03-01 10:33 ` Jesper Dangaard Brouer
2024-03-01 10:40 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214101450.25ee7e5d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).