From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
"Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Marek Behún" <kabel@kernel.org>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org
Subject: Re: [PATCH net-next v7 00/13] Introduce PHY listing and link_topology tracking
Date: Wed, 14 Feb 2024 16:59:02 -0800 [thread overview]
Message-ID: <20240214165902.55bf3a04@kernel.org> (raw)
In-Reply-To: <20240213150431.1796171-1-maxime.chevallier@bootlin.com>
On Tue, 13 Feb 2024 16:04:17 +0100 Maxime Chevallier wrote:
> This is V7 for the link topology addition, allowing to track all PHYs
> that are linked to netdevices.
>
> The main change in V7 is the protection of the main internal API
> entrypoints (link_topo_init/cleanup, link_topo_add/del_phy) by
> IS_REACHABLE(CONFIG_PHYLIB).
>
> That's restrictive, but it looks difficult to do otherwise while still keep the
> data structure opaque and not add dependency clutter with PHYLIB.
>
> As you can tell, I'm unsure about this, so please don't hesitate to
> comment on that part :)
>
> The other changes are very minor, the only one is a call to netdev_put
> in the .done() netlink callback.
>
> As a remainder, here's what the PHY listings would look like :
> - eth0 has a 88x3310 acting as media converter, and an SFP module with
> an embedded 88e1111 PHY
> - eth2 has a 88e1510 PHY
Needs a rebase, core has been busy lately:
Applying: net: phy: Introduce ethernet link topology representation
Using index info to reconstruct a base tree...
M MAINTAINERS
M drivers/net/phy/Makefile
M drivers/net/phy/phy_device.c
M include/linux/netdevice.h
M include/linux/phy.h
M net/core/dev.c
Falling back to patching base and 3-way merge...
Auto-merging net/core/dev.c
CONFLICT (content): Merge conflict in net/core/dev.c
Auto-merging include/linux/phy.h
Auto-merging include/linux/netdevice.h
Auto-merging drivers/net/phy/phy_device.c
Auto-merging drivers/net/phy/Makefile
Auto-merging MAINTAINERS
Recorded preimage for 'net/core/dev.c'
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-15 0:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 15:04 [PATCH net-next v7 00/13] Introduce PHY listing and link_topology tracking Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 01/13] net: phy: Introduce ethernet link topology representation Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 04/13] net: sfp: Add helper to return the SFP bus name Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 05/13] net: ethtool: Allow passing a phy index for some commands Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 06/13] netlink: specs: add phy-index as a header parameter Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 07/13] net: ethtool: Introduce a command to list PHYs on an interface Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 08/13] netlink: specs: add ethnl PHY_GET command set Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 09/13] net: ethtool: plca: Target the command to the requested PHY Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 10/13] net: ethtool: pse-pd: " Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 11/13] net: ethtool: cable-test: " Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 12/13] net: ethtool: strset: Allow querying phy stats by index Maxime Chevallier
2024-02-13 15:04 ` [PATCH net-next v7 13/13] Documentation: networking: document phy_link_topology Maxime Chevallier
2024-02-15 0:59 ` Jakub Kicinski [this message]
2024-02-15 7:19 ` [PATCH net-next v7 00/13] Introduce PHY listing and link_topology tracking Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214165902.55bf3a04@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).