From: Stephen Hemminger <stephen@networkplumber.org>
To: Maks Mishin <maks.mishinfz@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] json_print: Add explicit condition in print_color_string()
Date: Wed, 14 Feb 2024 19:00:10 -0800 [thread overview]
Message-ID: <20240214190010.2be170ed@hermes.local> (raw)
In-Reply-To: <20240213204009.13625-1-maks.mishinFZ@gmail.com>
On Tue, 13 Feb 2024 23:40:09 +0300
Maks Mishin <maks.mishinfz@gmail.com> wrote:
> Added explicit condition for check `key` and `value`
> in print_color_string() to avoid call `jsonw_string_field`
> with key=NULL and value=NULL.
>
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
Thanks for the patch, but looks like another potential issue
found by a checker. Anything calling print_color_string and wanting
to print a json string with key and value of NULL is broken.
This change would paper over a real bug.
Do you have a test case where this occurs?
prev parent reply other threads:[~2024-02-15 3:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 20:40 [PATCH] json_print: Add explicit condition in print_color_string() Maks Mishin
2024-02-15 3:00 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214190010.2be170ed@hermes.local \
--to=stephen@networkplumber.org \
--cc=maks.mishinfz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).