From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>, <netdev@vger.kernel.org>,
<lorenzo.bianconi@redhat.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <hawk@kernel.org>,
<ilias.apalodimas@linaro.org>, <linyunsheng@huawei.com>,
<toke@redhat.com>
Subject: Re: [RFC net-next] net: page_pool: fix recycle stats for percpu page_pool allocator
Date: Thu, 15 Feb 2024 07:04:14 -0800 [thread overview]
Message-ID: <20240215070414.4d522c88@kernel.org> (raw)
In-Reply-To: <bff45ab9-2818-4b37-837e-f18ffcab8f47@intel.com>
On Thu, 15 Feb 2024 14:41:52 +0100 Alexander Lobakin wrote:
> For example, if I have an Rx queue always pinned to one CPU, I might
> want to create a PP for this queue with the cpuid set already to save
> some cycles when recycling. We might also reuse cpuid later for some
> more optimizations or features.
You say "pin Rx queue to one CPU" like that's actually possible to do
reliably :)
> Maybe add a new PP_FLAG indicating that system percpu PP stats should be
> used?
Part of me feels like checking the dev pointer would be good enough.
It may make sense to create more per CPU pools for particular devices
further down, but creating more pools without no dev / DMA mapping
makes no sense, right?
Dunno if looking at dev is not too hacky, tho, flags are cheap.
next prev parent reply other threads:[~2024-02-15 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 18:08 [RFC net-next] net: page_pool: fix recycle stats for percpu page_pool allocator Lorenzo Bianconi
2024-02-14 21:42 ` Toke Høiland-Jørgensen
2024-02-14 22:46 ` Lorenzo Bianconi
2024-02-15 13:41 ` Alexander Lobakin
2024-02-15 13:51 ` Lorenzo Bianconi
2024-02-15 15:04 ` Jakub Kicinski [this message]
2024-02-15 15:31 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215070414.4d522c88@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linyunsheng@huawei.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).