From: Christian Brauner <brauner@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH 1/2] kobject: make uevent_seqnum atomic
Date: Fri, 16 Feb 2024 15:52:13 +0100 [thread overview]
Message-ID: <20240216-fluggast-wohnt-17a30f7420d4@brauner> (raw)
In-Reply-To: <20240214084829.684541-2-edumazet@google.com>
On Wed, Feb 14, 2024 at 08:48:28AM +0000, Eric Dumazet wrote:
> We will soon no longer acquire uevent_sock_mutex
> for most kobject_uevent_net_broadcast() calls,
> and also while calling uevent_net_broadcast().
>
> Make uevent_seqnum an atomic64_t to get its own protection.
>
> This fixes a race while reading /sys/kernel/uevent_seqnum.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Christian Brauner <brauner@kernel.org>
> ---
Nice,
Reviewed-by: Christian Brauner <brauner@kernel.org>
next prev parent reply other threads:[~2024-02-16 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 8:48 [PATCH 0/2] kobject: reduce uevent_sock_mutex contention Eric Dumazet
2024-02-14 8:48 ` [PATCH 1/2] kobject: make uevent_seqnum atomic Eric Dumazet
2024-02-16 14:52 ` Christian Brauner [this message]
2024-02-14 8:48 ` [PATCH 2/2] kobject: reduce uevent_sock_mutex scope Eric Dumazet
2024-02-16 14:53 ` Christian Brauner
2024-02-14 10:27 ` [PATCH 0/2] kobject: reduce uevent_sock_mutex contention Greg Kroah-Hartman
2024-02-14 10:43 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216-fluggast-wohnt-17a30f7420d4@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox