From: Maks Mishin <maks.mishinfz@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Maks Mishin <maks.mishinFZ@gmail.com>, netdev@vger.kernel.org
Subject: [PATCH] m_ife: Remove unused value
Date: Sun, 18 Feb 2024 22:44:13 +0300 [thread overview]
Message-ID: <20240218194413.31742-1-maks.mishinFZ@gmail.com> (raw)
The variable `has_optional` do not used after set the value.
Found by RASU JSC.
Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
tc/m_ife.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tc/m_ife.c b/tc/m_ife.c
index 162607ce..42621bec 100644
--- a/tc/m_ife.c
+++ b/tc/m_ife.c
@@ -291,7 +291,6 @@ static int print_ife(struct action_util *au, FILE *f, struct rtattr *arg)
}
if (tb[TCA_IFE_DMAC]) {
- has_optional = 1;
print_string(PRINT_ANY, "dst", "dst %s ",
ll_addr_n2a(RTA_DATA(tb[TCA_IFE_DMAC]),
RTA_PAYLOAD(tb[TCA_IFE_DMAC]), 0, b2,
@@ -299,7 +298,6 @@ static int print_ife(struct action_util *au, FILE *f, struct rtattr *arg)
}
if (tb[TCA_IFE_SMAC]) {
- has_optional = 1;
print_string(PRINT_ANY, "src", "src %s ",
ll_addr_n2a(RTA_DATA(tb[TCA_IFE_SMAC]),
RTA_PAYLOAD(tb[TCA_IFE_SMAC]), 0, b2,
--
2.30.2
next reply other threads:[~2024-02-18 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 19:44 Maks Mishin [this message]
2024-02-19 17:59 ` [PATCH] m_ife: Remove unused value Stephen Hemminger
2024-02-20 14:32 ` Jamal Hadi Salim
-- strict thread matches above, loose matches on Subject: below --
2024-04-17 17:07 Maks Mishin
[not found] ` <CAEh9MGTwqGVpuq8M+So8bfU2y=bpbQMJjPJo3F52MjFHQ_BiRQ@mail.gmail.com>
2024-04-17 22:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240218194413.31742-1-maks.mishinFZ@gmail.com \
--to=maks.mishinfz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).