From: Jason Xing <kerneljasonxing@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org, kuniyu@amazon.com
Cc: netdev@vger.kernel.org, kerneljasonxing@gmail.com,
Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next v6 01/11] tcp: add a dropreason definitions and prepare for cookie check
Date: Mon, 19 Feb 2024 11:28:28 +0800 [thread overview]
Message-ID: <20240219032838.91723-2-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240219032838.91723-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
Only add one drop reason to detect the condition of skb dropped
because of hook points in cookie check for later use.
Signed-off-by: Jason Xing <kernelxing@tencent.com>
--
v6
Link: https://lore.kernel.org/netdev/20240215210922.19969-1-kuniyu@amazon.com/
1. Modify the description NO_SOCKET to extend other two kinds of invalid
socket cases.
What I think about it is we can use it as a general indicator for three kinds of
sockets which are invalid/NULL, like what we did to TCP_FLAGS.
Any better ideas/suggestions are welcome :)
v5
Link: https://lore.kernel.org/netdev/CANn89i+iELpsoea6+C-08m6+=JkneEEM=nAj-28eNtcOCkwQjw@mail.gmail.com/
Link: https://lore.kernel.org/netdev/632c6fd4-e060-4b8e-a80e-5d545a6c6b6c@kernel.org/
1. Use SKB_DROP_REASON_IP_OUTNOROUTES instead of introducing a new one (Eric, David)
2. Reuse SKB_DROP_REASON_NOMEM to handle failure of request socket allocation (Eric)
3. Reuse NO_SOCKET instead of introducing COOKIE_NOCHILD
4. Reuse IP_OUTNOROUTES instead of INVALID_DST (Eric)
5. adjust the title and description.
v4
Link: https://lore.kernel.org/netdev/20240212172302.3f95e454@kernel.org/
1. fix misspelled name in kdoc as Jakub said
---
include/net/dropreason-core.h | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/include/net/dropreason-core.h b/include/net/dropreason-core.h
index 6d3a20163260..3c867384dead 100644
--- a/include/net/dropreason-core.h
+++ b/include/net/dropreason-core.h
@@ -54,6 +54,7 @@
FN(NEIGH_QUEUEFULL) \
FN(NEIGH_DEAD) \
FN(TC_EGRESS) \
+ FN(SECURITY_HOOK) \
FN(QDISC_DROP) \
FN(CPU_BACKLOG) \
FN(XDP) \
@@ -105,7 +106,13 @@ enum skb_drop_reason {
SKB_CONSUMED,
/** @SKB_DROP_REASON_NOT_SPECIFIED: drop reason is not specified */
SKB_DROP_REASON_NOT_SPECIFIED,
- /** @SKB_DROP_REASON_NO_SOCKET: socket not found */
+ /**
+ * @SKB_DROP_REASON_NO_SOCKET: no invalid socket that can be used.
+ * Reason could be one of three cases:
+ * 1) no established/listening socket found during lookup process
+ * 2) no invalid request socket during 3WHS process
+ * 3) no invalid child socket during 3WHS process
+ */
SKB_DROP_REASON_NO_SOCKET,
/** @SKB_DROP_REASON_PKT_TOO_SMALL: packet size is too small */
SKB_DROP_REASON_PKT_TOO_SMALL,
@@ -271,6 +278,8 @@ enum skb_drop_reason {
SKB_DROP_REASON_NEIGH_DEAD,
/** @SKB_DROP_REASON_TC_EGRESS: dropped in TC egress HOOK */
SKB_DROP_REASON_TC_EGRESS,
+ /** @SKB_DROP_REASON_SECURITY_HOOK: dropped due to security HOOK */
+ SKB_DROP_REASON_SECURITY_HOOK,
/**
* @SKB_DROP_REASON_QDISC_DROP: dropped by qdisc when packet outputting (
* failed to enqueue to current qdisc)
--
2.37.3
next prev parent reply other threads:[~2024-02-19 3:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 3:28 [PATCH net-next v6 00/11] introduce drop reasons for tcp receive path Jason Xing
2024-02-19 3:28 ` Jason Xing [this message]
2024-02-19 4:06 ` [PATCH net-next v6 01/11] tcp: add a dropreason definitions and prepare for cookie check Kuniyuki Iwashima
2024-02-19 4:56 ` Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 02/11] tcp: directly drop skb in cookie check for ipv4 Jason Xing
2024-02-19 4:13 ` Kuniyuki Iwashima
2024-02-19 3:28 ` [PATCH net-next v6 03/11] tcp: use drop reasons " Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 04/11] tcp: directly drop skb in cookie check for ipv6 Jason Xing
2024-02-19 4:38 ` Kuniyuki Iwashima
2024-02-19 4:57 ` Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 05/11] tcp: use drop reasons " Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 06/11] tcp: introduce dropreasons in receive path Jason Xing
2024-02-19 4:47 ` Kuniyuki Iwashima
2024-02-19 4:57 ` Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 07/11] tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process() Jason Xing
2024-02-19 4:54 ` Kuniyuki Iwashima
2024-02-19 5:07 ` Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 08/11] tcp: add dropreasons in tcp_rcv_state_process() Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 09/11] tcp: make the dropreason really work when calling tcp_rcv_state_process() Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 10/11] tcp: make dropreason in tcp_child_process() work Jason Xing
2024-02-19 3:28 ` [PATCH net-next v6 11/11] tcp: get rid of NOT_SPECIFIED reason in tcp_v4/6_do_rcv Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219032838.91723-2-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).