netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Xing <kerneljasonxing@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, dsahern@kernel.org, kuniyu@amazon.com
Cc: netdev@vger.kernel.org, kerneljasonxing@gmail.com,
	Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next v6 07/11] tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process()
Date: Mon, 19 Feb 2024 11:28:34 +0800	[thread overview]
Message-ID: <20240219032838.91723-8-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240219032838.91723-1-kerneljasonxing@gmail.com>

From: Jason Xing <kernelxing@tencent.com>

This patch does two things:
1) add two more new reasons
2) only change the return value(1) to various drop reason values
for the future use

For now, we still cannot trace those two reasons. We'll implement the full
function in the subsequent patch in this serie.

Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
 net/ipv4/tcp_input.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 74c03f0a6c0c..83308cca1610 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -6361,6 +6361,7 @@ static int tcp_rcv_synsent_state_process(struct sock *sk, struct sk_buff *skb,
 				inet_csk_reset_xmit_timer(sk,
 						ICSK_TIME_RETRANS,
 						TCP_TIMEOUT_MIN, TCP_RTO_MAX);
+			SKB_DR_SET(reason, TCP_INVALID_ACK_SEQUENCE);
 			goto reset_and_undo;
 		}
 
@@ -6369,6 +6370,7 @@ static int tcp_rcv_synsent_state_process(struct sock *sk, struct sk_buff *skb,
 			     tcp_time_stamp_ts(tp))) {
 			NET_INC_STATS(sock_net(sk),
 					LINUX_MIB_PAWSACTIVEREJECTED);
+			SKB_DR_SET(reason, TCP_RFC7323_PAWS);
 			goto reset_and_undo;
 		}
 
@@ -6572,7 +6574,8 @@ static int tcp_rcv_synsent_state_process(struct sock *sk, struct sk_buff *skb,
 reset_and_undo:
 	tcp_clear_options(&tp->rx_opt);
 	tp->rx_opt.mss_clamp = saved_clamp;
-	return 1;
+	/* we can reuse/return @reason to its caller to handle the exception */
+	return reason;
 }
 
 static void tcp_rcv_synrecv_state_fastopen(struct sock *sk)
-- 
2.37.3


  parent reply	other threads:[~2024-02-19  3:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19  3:28 [PATCH net-next v6 00/11] introduce drop reasons for tcp receive path Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 01/11] tcp: add a dropreason definitions and prepare for cookie check Jason Xing
2024-02-19  4:06   ` Kuniyuki Iwashima
2024-02-19  4:56     ` Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 02/11] tcp: directly drop skb in cookie check for ipv4 Jason Xing
2024-02-19  4:13   ` Kuniyuki Iwashima
2024-02-19  3:28 ` [PATCH net-next v6 03/11] tcp: use drop reasons " Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 04/11] tcp: directly drop skb in cookie check for ipv6 Jason Xing
2024-02-19  4:38   ` Kuniyuki Iwashima
2024-02-19  4:57     ` Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 05/11] tcp: use drop reasons " Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 06/11] tcp: introduce dropreasons in receive path Jason Xing
2024-02-19  4:47   ` Kuniyuki Iwashima
2024-02-19  4:57     ` Jason Xing
2024-02-19  3:28 ` Jason Xing [this message]
2024-02-19  4:54   ` [PATCH net-next v6 07/11] tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process() Kuniyuki Iwashima
2024-02-19  5:07     ` Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 08/11] tcp: add dropreasons in tcp_rcv_state_process() Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 09/11] tcp: make the dropreason really work when calling tcp_rcv_state_process() Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 10/11] tcp: make dropreason in tcp_child_process() work Jason Xing
2024-02-19  3:28 ` [PATCH net-next v6 11/11] tcp: get rid of NOT_SPECIFIED reason in tcp_v4/6_do_rcv Jason Xing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240219032838.91723-8-kerneljasonxing@gmail.com \
    --to=kerneljasonxing@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kernelxing@tencent.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).