From: Stephen Hemminger <stephen@networkplumber.org>
To: Maks Mishin <maks.mishinfz@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] m_tunnel_key: Add check for result hex2mem()
Date: Mon, 19 Feb 2024 10:06:21 -0800 [thread overview]
Message-ID: <20240219100621.7bbb708e@hermes.local> (raw)
In-Reply-To: <20240218204026.7273-1-maks.mishinFZ@gmail.com>
On Sun, 18 Feb 2024 23:40:26 +0300
Maks Mishin <maks.mishinfz@gmail.com> wrote:
> Added check for hex2mem() result to report of error
> with incorrect args.
>
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
> ---
> tc/m_tunnel_key.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tc/m_tunnel_key.c b/tc/m_tunnel_key.c
> index ff699cc8..9bb5c2aa 100644
> --- a/tc/m_tunnel_key.c
> +++ b/tc/m_tunnel_key.c
> @@ -575,7 +575,10 @@ static void tunnel_key_print_geneve_options(struct rtattr *attr)
> data_len = RTA_PAYLOAD(tb[TCA_TUNNEL_KEY_ENC_OPT_GENEVE_DATA]);
> hexstring_n2a(RTA_DATA(tb[TCA_TUNNEL_KEY_ENC_OPT_GENEVE_DATA]),
> data_len, data, sizeof(data));
> - hex2mem(data, data_r, data_len);
> +
> + if (hex2mem(data, data_r, data_len) < 0)
> + invarg("labels mask must be a hex string\n", data);
> +
invarg() is intended only for use in command line args.
This is where the result of a geneve option from kernel netlink is being parsed.
Not user input.
Not sure why hex2mem is needed here at all? The original data is in the
netlink message. Doing the inverse is redundant.
prev parent reply other threads:[~2024-02-19 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 20:40 [PATCH] m_tunnel_key: Add check for result hex2mem() Maks Mishin
2024-02-19 18:06 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219100621.7bbb708e@hermes.local \
--to=stephen@networkplumber.org \
--cc=maks.mishinfz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox