* [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg
@ 2024-02-18 18:04 Heiner Kallweit
2024-02-19 19:37 ` Simon Horman
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Heiner Kallweit @ 2024-02-18 18:04 UTC (permalink / raw)
To: Pavan Chebbi, Michael Chan, Paolo Abeni, Eric Dumazet,
Jakub Kicinski, David Miller, Andrew Lunn
Cc: netdev@vger.kernel.org
Make use of ethtool_adv_to_mmd_eee_adv_t() to simplify the code.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/broadcom/tg3.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 7a07c5216..62ff4381a 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -4354,21 +4354,12 @@ static int tg3_phy_autoneg_cfg(struct tg3 *tp, u32 advertise, u32 flowctrl)
if (!err) {
u32 err2;
- val = 0;
- /* Advertise 100-BaseTX EEE ability */
- if (advertise & ADVERTISED_100baseT_Full)
- val |= MDIO_AN_EEE_ADV_100TX;
- /* Advertise 1000-BaseT EEE ability */
- if (advertise & ADVERTISED_1000baseT_Full)
- val |= MDIO_AN_EEE_ADV_1000T;
-
- if (!tp->eee.eee_enabled) {
+ if (!tp->eee.eee_enabled)
val = 0;
- linkmode_zero(tp->eee.advertised);
- } else {
- mii_eee_cap1_mod_linkmode_t(tp->eee.advertised, val);
- }
+ else
+ val = ethtool_adv_to_mmd_eee_adv_t(advertise);
+ mii_eee_cap1_mod_linkmode_t(tp->eee.advertised, val);
err = tg3_phy_cl45_write(tp, MDIO_MMD_AN, MDIO_AN_EEE_ADV, val);
if (err)
val = 0;
--
2.43.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg
2024-02-18 18:04 [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg Heiner Kallweit
@ 2024-02-19 19:37 ` Simon Horman
2024-02-20 1:54 ` Kalesh Anakkur Purayil
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2024-02-19 19:37 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Pavan Chebbi, Michael Chan, Paolo Abeni, Eric Dumazet,
Jakub Kicinski, David Miller, Andrew Lunn, netdev@vger.kernel.org
On Sun, Feb 18, 2024 at 07:04:42PM +0100, Heiner Kallweit wrote:
> Make use of ethtool_adv_to_mmd_eee_adv_t() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg
2024-02-18 18:04 [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg Heiner Kallweit
2024-02-19 19:37 ` Simon Horman
@ 2024-02-20 1:54 ` Kalesh Anakkur Purayil
2024-02-20 14:48 ` Andrew Lunn
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kalesh Anakkur Purayil @ 2024-02-20 1:54 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Pavan Chebbi, Michael Chan, Paolo Abeni, Eric Dumazet,
Jakub Kicinski, David Miller, Andrew Lunn, netdev@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]
On Sun, Feb 18, 2024 at 11:34 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Make use of ethtool_adv_to_mmd_eee_adv_t() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 17 ++++-------------
> 1 file changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 7a07c5216..62ff4381a 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -4354,21 +4354,12 @@ static int tg3_phy_autoneg_cfg(struct tg3 *tp, u32 advertise, u32 flowctrl)
> if (!err) {
> u32 err2;
>
> - val = 0;
> - /* Advertise 100-BaseTX EEE ability */
> - if (advertise & ADVERTISED_100baseT_Full)
> - val |= MDIO_AN_EEE_ADV_100TX;
> - /* Advertise 1000-BaseT EEE ability */
> - if (advertise & ADVERTISED_1000baseT_Full)
> - val |= MDIO_AN_EEE_ADV_1000T;
> -
> - if (!tp->eee.eee_enabled) {
> + if (!tp->eee.eee_enabled)
> val = 0;
> - linkmode_zero(tp->eee.advertised);
> - } else {
> - mii_eee_cap1_mod_linkmode_t(tp->eee.advertised, val);
> - }
> + else
> + val = ethtool_adv_to_mmd_eee_adv_t(advertise);
>
> + mii_eee_cap1_mod_linkmode_t(tp->eee.advertised, val);
> err = tg3_phy_cl45_write(tp, MDIO_MMD_AN, MDIO_AN_EEE_ADV, val);
> if (err)
> val = 0;
> --
> 2.43.2
>
>
--
Regards,
Kalesh A P
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg
2024-02-18 18:04 [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg Heiner Kallweit
2024-02-19 19:37 ` Simon Horman
2024-02-20 1:54 ` Kalesh Anakkur Purayil
@ 2024-02-20 14:48 ` Andrew Lunn
2024-02-20 19:31 ` Michael Chan
2024-02-21 11:20 ` patchwork-bot+netdevbpf
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2024-02-20 14:48 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Pavan Chebbi, Michael Chan, Paolo Abeni, Eric Dumazet,
Jakub Kicinski, David Miller, netdev@vger.kernel.org
On Sun, Feb 18, 2024 at 07:04:42PM +0100, Heiner Kallweit wrote:
> Make use of ethtool_adv_to_mmd_eee_adv_t() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg
2024-02-18 18:04 [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg Heiner Kallweit
` (2 preceding siblings ...)
2024-02-20 14:48 ` Andrew Lunn
@ 2024-02-20 19:31 ` Michael Chan
2024-02-21 11:20 ` patchwork-bot+netdevbpf
4 siblings, 0 replies; 6+ messages in thread
From: Michael Chan @ 2024-02-20 19:31 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Pavan Chebbi, Michael Chan, Paolo Abeni, Eric Dumazet,
Jakub Kicinski, David Miller, Andrew Lunn, netdev@vger.kernel.org
On Sun, Feb 18, 2024 at 10:04 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Make use of ethtool_adv_to_mmd_eee_adv_t() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Thanks.
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg
2024-02-18 18:04 [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg Heiner Kallweit
` (3 preceding siblings ...)
2024-02-20 19:31 ` Michael Chan
@ 2024-02-21 11:20 ` patchwork-bot+netdevbpf
4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-21 11:20 UTC (permalink / raw)
To: Heiner Kallweit
Cc: pavan.chebbi, mchan, pabeni, edumazet, kuba, davem, andrew,
netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Sun, 18 Feb 2024 19:04:42 +0100 you wrote:
> Make use of ethtool_adv_to_mmd_eee_adv_t() to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 17 ++++-------------
> 1 file changed, 4 insertions(+), 13 deletions(-)
Here is the summary with links:
- [net-next] tg3: simplify tg3_phy_autoneg_cfg
https://git.kernel.org/netdev/net-next/c/ebb0346a117f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-21 11:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-18 18:04 [PATCH net-next] tg3: simplify tg3_phy_autoneg_cfg Heiner Kallweit
2024-02-19 19:37 ` Simon Horman
2024-02-20 1:54 ` Kalesh Anakkur Purayil
2024-02-20 14:48 ` Andrew Lunn
2024-02-20 19:31 ` Michael Chan
2024-02-21 11:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).