From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B676101C2 for ; Wed, 21 Feb 2024 00:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708476731; cv=none; b=T+dSsCL+xe8w3Ja8WdFR9ks3oxrpEaY0HtW1d0kScpqCdmow6I4czOR4zUPXc0RgpqoF3sfBtFdYpuSOoYDZPRfutGAHaugq33bLLAx/AVrhN7A2cqfkWr/dkYRPtPGyptis+KNflFAGXtwZkB89OeM63J9HP4WY77MO8KuROqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708476731; c=relaxed/simple; bh=9WK94qUvGMIRtk5etx9mPVS0NZhg+Y0iswprAI7O23g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OFxM/hzuAQdKcVarG8kvMxJAoavDdMbgfRS2cug39LxTY77ol4oIQqnddbYx6eZB2/XcuwZ4JjcHiWkvMvJzYMY6sFFG0hADzo8js713wnP/Dnw2y8ev1aIrHKRl9LKyc8sU//tLai01kw0YdPtS9G3txADCYkBXSTzj92AhoKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=KsyUGATl; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KsyUGATl" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6e3ffafa708so3093347b3a.1 for ; Tue, 20 Feb 2024 16:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708476729; x=1709081529; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2lCsz+v1VYXLr/Jnw9QhtpXgqVzJI761uB6BfnSGSFk=; b=KsyUGATlaZzXszYjBLJulj5f/Z7Kazsm0oYKerlLwdKMzYN9Fl5TRD6KwUgKRocFgc CcGRHHqp4eWDVzOhXFwtg+NG8Yq+yaXGs0N4Q+jIm2wEC36QIQEz5KKe8+PbsjqgF+RH 7+29cTGKNw37BA5olsmu+o7MYnPHrkP8oeAXw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708476729; x=1709081529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2lCsz+v1VYXLr/Jnw9QhtpXgqVzJI761uB6BfnSGSFk=; b=OUplxbbZNg6DmcNMD5XxvLFjDWxOazsfFWnFDozeBHJakNyzSlqLXSi3m71Fc2A4iY 5dF977oSAvdPoAoD9b7cSSxXkqa6ODfuGq7ctvb+0CIsFv8Wis9QczoIm7+UPMTMy9aQ 45qHUTb/mRfmMeBAxz08geyvB6AD7QJVuDAvx0gaMMYK7a9dtpcsd8u2/jUPqEda4Qka UqSBFRhvDgoqtzq96V4Dn/AFpOjpC+GqyUB0ZUkGc5huJQZS8KkeQlaTYs0cpRyLPmPc bcJXLLk9zESPywdL3z4epvZZBy5jWT2Sqaoxu+7hKOZnCYfE2cWeTSgDKrDJ+YZj1F0g +fMQ== X-Forwarded-Encrypted: i=1; AJvYcCWHUBFrXb4UQAmFTLziS/WqIk8upnFuwXiGNlfh7vbe4iaR0AdeicHVzJj3zuXM4UkLRUbxvuqQkWM5bhyn5uEuKhWMkguA X-Gm-Message-State: AOJu0YxcVaI7CNNXh0ebGab0MXnFAb/F7LmkY65VVH5RcgbksddF9KGi LgYZz3hMd4HcwtS/m6wM8ixazdu4KhUPYGS9mwkSossnWQMKTm3ayogiuddJqca7k0U+h7VDpqs = X-Google-Smtp-Source: AGHT+IGDKq1WFUbJKN04lJUQbFzZp5Vh6ABFfgeZYdhAWawTlpOMDmSDbq+YYY1nfxnYxMDPBoRY+w== X-Received: by 2002:a05:6a00:22cc:b0:6e4:5a51:80f9 with SMTP id f12-20020a056a0022cc00b006e45a5180f9mr11536963pfj.22.1708476728817; Tue, 20 Feb 2024 16:52:08 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id c11-20020aa781cb000000b006e11455bebbsm7431202pfn.84.2024.02.20.16.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 16:52:08 -0800 (PST) Date: Tue, 20 Feb 2024 16:52:07 -0800 From: Kees Cook To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, mic@digikod.net, linux-security-module@vger.kernel.org, jakub@cloudflare.com Subject: Re: [PATCH net-next v3 10/11] selftests: kselftest_harness: support using xfail Message-ID: <202402201651.7C25039529@keescook> References: <20240220192235.2953484-1-kuba@kernel.org> <20240220192235.2953484-11-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220192235.2953484-11-kuba@kernel.org> On Tue, Feb 20, 2024 at 11:22:34AM -0800, Jakub Kicinski wrote: > Currently some tests report skip for things they expect to fail > e.g. when given combination of parameters is known to be unsupported. > This is confusing because in an ideal test environment and fully > featured kernel no tests should be skipped. > > Selftest summary line already includes xfail and xpass counters, > e.g.: > > but there's no way to use it from within the harness. > > Add a new per-fixture+variant combination list of test cases > we expect to fail. > > Signed-off-by: Jakub Kicinski Thanks for this implementation; this will work nicely. :) Reviewed-by: Kees Cook -- Kees Cook