From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, horms@kernel.org
Subject: Re: [patch net] devlink: fix port dump cmd type
Date: Tue, 20 Feb 2024 18:36:10 -0800 [thread overview]
Message-ID: <20240220183610.5d00de89@kernel.org> (raw)
In-Reply-To: <20240220075245.75416-1-jiri@resnulli.us>
On Tue, 20 Feb 2024 08:52:45 +0100 Jiri Pirko wrote:
> Unlike other commands, due to a c&p error, port dump fills-up cmd with
> wrong value, different from port-get request cmd, port-get doit reply
> and port notification.
>
> Fix it by filling cmd with value DEVLINK_CMD_PORT_NEW.
>
> Skimmed through devlink userspace implementations, none of them cares
> about this cmd value. Only ynl, for which, this is actually a fix, as it
> expects doit and dumpit ops rsp_value to be the same.
>
> Omit the fixes tag, even thought this is fix, better to target this for
> next release.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2024-02-21 2:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 7:52 [patch net] devlink: fix port dump cmd type Jiri Pirko
2024-02-21 2:36 ` Jakub Kicinski [this message]
2024-02-22 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220183610.5d00de89@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).