From: Jason Xing <kerneljasonxing@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org, kuniyu@amazon.com
Cc: netdev@vger.kernel.org, kerneljasonxing@gmail.com,
Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next v7 09/11] tcp: make the dropreason really work when calling tcp_rcv_state_process()
Date: Wed, 21 Feb 2024 10:57:29 +0800 [thread overview]
Message-ID: <20240221025732.68157-10-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240221025732.68157-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
Update three callers including both ipv4 and ipv6 and let the dropreason
mechanism work in reality.
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
include/net/tcp.h | 2 +-
net/ipv4/tcp_ipv4.c | 3 ++-
net/ipv4/tcp_minisocks.c | 9 +++++----
net/ipv6/tcp_ipv6.c | 3 ++-
4 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index e5af9a5b411b..1d9b2a766b5e 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -396,7 +396,7 @@ enum tcp_tw_status tcp_timewait_state_process(struct inet_timewait_sock *tw,
struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,
struct request_sock *req, bool fastopen,
bool *lost_race);
-int tcp_child_process(struct sock *parent, struct sock *child,
+enum skb_drop_reason tcp_child_process(struct sock *parent, struct sock *child,
struct sk_buff *skb);
void tcp_enter_loss(struct sock *sk);
void tcp_cwnd_reduction(struct sock *sk, int newly_acked_sacked, int newly_lost, int flag);
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 0a944e109088..c79e25549972 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1926,7 +1926,8 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
} else
sock_rps_save_rxhash(sk, skb);
- if (tcp_rcv_state_process(sk, skb)) {
+ reason = tcp_rcv_state_process(sk, skb);
+ if (reason) {
rsk = sk;
goto reset;
}
diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
index 9e85f2a0bddd..08d5b48540ea 100644
--- a/net/ipv4/tcp_minisocks.c
+++ b/net/ipv4/tcp_minisocks.c
@@ -911,11 +911,12 @@ EXPORT_SYMBOL(tcp_check_req);
* be created.
*/
-int tcp_child_process(struct sock *parent, struct sock *child,
+enum skb_drop_reason
+tcp_child_process(struct sock *parent, struct sock *child,
struct sk_buff *skb)
__releases(&((child)->sk_lock.slock))
{
- int ret = 0;
+ enum skb_drop_reason reason = SKB_NOT_DROPPED_YET;
int state = child->sk_state;
/* record sk_napi_id and sk_rx_queue_mapping of child. */
@@ -923,7 +924,7 @@ int tcp_child_process(struct sock *parent, struct sock *child,
tcp_segs_in(tcp_sk(child), skb);
if (!sock_owned_by_user(child)) {
- ret = tcp_rcv_state_process(child, skb);
+ reason = tcp_rcv_state_process(child, skb);
/* Wakeup parent, send SIGIO */
if (state == TCP_SYN_RECV && child->sk_state != state)
parent->sk_data_ready(parent);
@@ -937,6 +938,6 @@ int tcp_child_process(struct sock *parent, struct sock *child,
bh_unlock_sock(child);
sock_put(child);
- return ret;
+ return reason;
}
EXPORT_SYMBOL(tcp_child_process);
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 0c180bb8187f..4f8464e04b7f 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1663,7 +1663,8 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
} else
sock_rps_save_rxhash(sk, skb);
- if (tcp_rcv_state_process(sk, skb))
+ reason = tcp_rcv_state_process(sk, skb);
+ if (reason)
goto reset;
if (opt_skb)
goto ipv6_pktoptions;
--
2.37.3
next prev parent reply other threads:[~2024-02-21 2:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 2:57 [PATCH net-next v7 00/11] introduce drop reasons for tcp receive path Jason Xing
2024-02-21 2:57 ` [PATCH net-next v7 01/11] tcp: add a dropreason definitions and prepare for cookie check Jason Xing
2024-02-21 9:35 ` Eric Dumazet
2024-02-21 2:57 ` [PATCH net-next v7 02/11] tcp: directly drop skb in cookie check for ipv4 Jason Xing
2024-02-21 9:28 ` Eric Dumazet
2024-02-21 2:57 ` [PATCH net-next v7 03/11] tcp: use drop reasons " Jason Xing
2024-02-21 9:34 ` Eric Dumazet
2024-02-22 2:52 ` Jason Xing
2024-02-21 2:57 ` [PATCH net-next v7 04/11] tcp: directly drop skb in cookie check for ipv6 Jason Xing
2024-02-21 9:36 ` Eric Dumazet
2024-02-21 2:57 ` [PATCH net-next v7 05/11] tcp: use drop reasons " Jason Xing
2024-02-21 9:37 ` Eric Dumazet
2024-02-21 2:57 ` [PATCH net-next v7 06/11] tcp: introduce dropreasons in receive path Jason Xing
2024-02-21 2:57 ` [PATCH net-next v7 07/11] tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process() Jason Xing
2024-02-21 9:59 ` Eric Dumazet
2024-02-21 2:57 ` [PATCH net-next v7 08/11] tcp: add dropreasons in tcp_rcv_state_process() Jason Xing
2024-02-21 10:12 ` Eric Dumazet
2024-02-21 2:57 ` Jason Xing [this message]
2024-02-21 14:42 ` [PATCH net-next v7 09/11] tcp: make the dropreason really work when calling tcp_rcv_state_process() Eric Dumazet
2024-02-21 2:57 ` [PATCH net-next v7 10/11] tcp: make dropreason in tcp_child_process() work Jason Xing
2024-02-21 14:44 ` Eric Dumazet
2024-02-22 2:25 ` Jason Xing
2024-02-21 2:57 ` [PATCH net-next v7 11/11] tcp: get rid of NOT_SPECIFIED reason in tcp_v4/6_do_rcv Jason Xing
2024-02-21 14:47 ` Eric Dumazet
2024-02-22 2:16 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221025732.68157-10-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).