From: Jakub Kicinski <kuba@kernel.org>
To: Jann Horn <jannh@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH] net: ethtool: avoid rebuilds on UTS_RELEASE change
Date: Wed, 21 Feb 2024 11:23:09 -0800 [thread overview]
Message-ID: <20240221112309.7d526047@kernel.org> (raw)
In-Reply-To: <20240220194244.2056384-1-jannh@google.com>
On Tue, 20 Feb 2024 20:42:44 +0100 Jann Horn wrote:
> Currently, when you switch between branches or something like that and
> rebuild, net/ethtool/ioctl.c has to be built again because it depends
> on UTS_RELEASE.
>
> By instead referencing a string variable stored in another object file,
> this can be avoided.
>
> Signed-off-by: Jann Horn <jannh@google.com>
> ---
> (alternatively we could also use the utsname info from the current UTS
> namespace, but that'd be a bit of a behavior change, and I wanted to
> keep this change a no-op)
Is this related to John's work from:
https://lore.kernel.org/all/20240131104851.2311358-1-john.g.garry@oracle.com/
?
next prev parent reply other threads:[~2024-02-21 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 19:42 [PATCH] net: ethtool: avoid rebuilds on UTS_RELEASE change Jann Horn
2024-02-21 19:23 ` Jakub Kicinski [this message]
2024-02-21 19:25 ` Jann Horn
2024-02-21 19:35 ` Jakub Kicinski
2024-02-22 8:08 ` John Garry
2024-02-24 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221112309.7d526047@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jannh@google.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).