From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AF261272CB for ; Wed, 21 Feb 2024 22:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708552874; cv=none; b=YOrHVZ+HXOTgEBdet4yLSbRzhmJEk6upKfRX20Zs0XA1H7ynThGNZQbufaQ95MWq2yVPtokDpW8lD0XVn0uiba/oFit50xqZJc2KEakurHNPWEtm1uvntRm97tMh4DH4xQg9fpsEc+ov+EILcPfXpnVHji+ZSJVplgodoCv10Qk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708552874; c=relaxed/simple; bh=wqGWw9nOiid78rmVoNJpLAKogw9OxxtIINANjebVuns=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L9iK25DnO/OIZ8iSuvsef6QP4QrQe/jab1XeE4mFCgVTJIw3DmyWF1zckgAgTowHt2oMij9Ijgxy3aW+gr5QDcFPOQR9WVcOPPAdAmclQwQUOf35jQ6sZGsnfXicKd9w4htDpsNMQOp2mE0MKnfa1Skuu5RkX2k7/Y4gRnfFMjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=bpj48WmF; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bpj48WmF" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1dc0d11d1b7so27338795ad.2 for ; Wed, 21 Feb 2024 14:01:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708552871; x=1709157671; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k+6LHH2NPUzYokJHyaMeg6P0BHjKGeB4TbkarefmniY=; b=bpj48WmFS/Iv/Pl0hg7lOS8zJgnv0NSStFCNmbJ6KEpuG46kTUN/691glGTo/3Ussp p+NO4+VI9TFFxK1I1IpwAumuQPpNmQosA0O5VcsIoRgOfll/Zs90O7tq42+7asod3qYo QfauMBovnb/+K04a39tMMdP5sPWShkQq8NrPA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708552871; x=1709157671; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k+6LHH2NPUzYokJHyaMeg6P0BHjKGeB4TbkarefmniY=; b=dKKbMKiITzUzpS9gYqqxjzLSCuRyAdWFYLK9AnFdywn7jCdmVjwo+AGty0S+QSVxkz YjckJ4D5i7+bxzyav85IGZcjGC06ott1+oh4I3mmPcr7v1IFyxAV+yzIyidCedn2KUn6 gSqC1EAXEnwXTCt0SofJVsJ42oiX3vqb8wIbjTaC0Am7ElsL99rIAhhp8GFVbOLbEYwm fiN6R61CGaKISvig/gd1USA2Bey9pMdYJwmEDihgF2UiPYTP52CZuWCU6fFuwA06ETBi 5yr1z0eUk1Rel8WeUqqUko7x1+R9wa+QRzQr2ehUkoZHirBZRjMATx4aMENME2Fen3qH pv8Q== X-Forwarded-Encrypted: i=1; AJvYcCVrENrqkSr49WO58BIEP+2ko7CFwIkdZvNYt620hEWSx8dIRd93VJNK1Xon80u8Pw0Da+oPDec/8bYsPR0oehaIRIkpqjXY X-Gm-Message-State: AOJu0Yw4fJljOQNo321TAbjipKUyHEAD4JBr38CizWSlL/cVF/WLPTLT JH6qlc4TKIyTL9wLcX0UIjubOVHsPEo5BTgBCxnMK5vG1x8THed/8aXfRwFLXQ== X-Google-Smtp-Source: AGHT+IEf5eKUQSWm+opFfaiF5eBQJmg0AXhYyA+h2y9jNbW7sOQuiyq0AM8mKQQVx25bJ6R/7Y4UCw== X-Received: by 2002:a17:902:f70f:b0:1dc:4b04:13d4 with SMTP id h15-20020a170902f70f00b001dc4b0413d4mr60269plo.8.1708552870628; Wed, 21 Feb 2024 14:01:10 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id k4-20020a170902e90400b001dbba4c8289sm8533989pld.202.2024.02.21.14.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 14:01:10 -0800 (PST) Date: Wed, 21 Feb 2024 14:01:09 -0800 From: Kees Cook To: Daniel Borkmann Cc: Mark Rutland , "Gustavo A . R . Silva" , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , Haowen Bai , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Yonghong Song , Jonathan Corbet , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Joanne Koong , Yafang Shao , Kui-Feng Lee , Anton Protopopov , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v4] bpf: Replace bpf_lpm_trie_key 0-length array with flexible array Message-ID: <202402211347.2AF2EC4621@keescook> References: <20240220185421.it.949-kees@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 21, 2024 at 05:39:55PM +0100, Daniel Borkmann wrote: > The build in BPF CI is still broken, did you try to build selftests? Okay, I give up. How is a mortal supposed to build these? If I try to follow what I see in https://github.com/libbpf/ci/blob/main/build-selftests/build_selftests.sh I just get more and more kinds of errors: In file included from progs/cb_refs.c:5: progs/../bpf_testmod/bpf_testmod_kfunc.h:29:8: error: redefinition of 'prog_test_pass1' 29 | struct prog_test_pass1 { | ^ /srv/code/tools/testing/selftests/bpf/tools/include/vmlinux.h:106850:8: note: previous definition is here 106850 | struct prog_test_pass1 { | ^ Messing around with deleting vmlinux.h seems to get me further, but later: /srv/code/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c: In function 'bpf_testmod_ops_is_valid_access': /srv/code/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:535:16: error: implicit declaration of function 'bpf_tracing_btf_ctx_access' [-Werror=implicit-function-declaration] 535 | return bpf_tracing_btf_ctx_access(off, size, type, prog, info); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ and then I'm stuck. It looks like the build isn't actually using KBUILD_OUTPUT for finding includes. If I try to add -I flags to the Makefile I just drown in new errors. -- Kees Cook