From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
"Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Marek Behún" <kabel@kernel.org>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org
Subject: Re: [PATCH net-next v8 08/13] netlink: specs: add ethnl PHY_GET command set
Date: Wed, 21 Feb 2024 17:00:23 -0800 [thread overview]
Message-ID: <20240221170023.452a01ca@kernel.org> (raw)
In-Reply-To: <20240220184217.3689988-9-maxime.chevallier@bootlin.com>
On Tue, 20 Feb 2024 19:42:11 +0100 Maxime Chevallier wrote:
> + -
> + name: upstream-phy-index
> + type: u32
The C define appears to be called:
ETHTOOL_A_PHY_UPSTREAM_INDEX, /* u32 */
either it needs to gain the PHY_ or the spec needs to lose the phy-,
otherwise C code gen gets upset:
ethtool-user.c:689:10: error: ‘ETHTOOL_A_PHY_UPSTREAM_PHY_INDEX’ undeclared here (not in a function); did you mean ‘ETHTOOL_A_PHY_UPSTREAM_INDEX’?
689 | [ETHTOOL_A_PHY_UPSTREAM_PHY_INDEX] = { .name = "upstream-phy-index", .type = YNL_PT_U32, },
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ETHTOOL_A_PHY_UPSTREAM_INDEX
Unfortunately ethtool in the in-between state where we can auto-gen
user space code (or rather most of it) but the uAPI header is not
auto-generated so we need to take extra care to keep things in sync :(
next prev parent reply other threads:[~2024-02-22 1:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 18:42 [PATCH net-next v8 00/13] Introduce PHY listing and link_topology tracking Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 01/13] net: phy: Introduce ethernet link topology representation Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 04/13] net: sfp: Add helper to return the SFP bus name Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 05/13] net: ethtool: Allow passing a phy index for some commands Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 06/13] netlink: specs: add phy-index as a header parameter Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 07/13] net: ethtool: Introduce a command to list PHYs on an interface Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 08/13] netlink: specs: add ethnl PHY_GET command set Maxime Chevallier
2024-02-22 1:00 ` Jakub Kicinski [this message]
2024-02-22 7:49 ` Maxime Chevallier
2024-02-22 23:10 ` Jakub Kicinski
2024-02-20 18:42 ` [PATCH net-next v8 09/13] net: ethtool: plca: Target the command to the requested PHY Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 10/13] net: ethtool: pse-pd: " Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 11/13] net: ethtool: cable-test: " Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 12/13] net: ethtool: strset: Allow querying phy stats by index Maxime Chevallier
2024-02-20 18:42 ` [PATCH net-next v8 13/13] Documentation: networking: document phy_link_topology Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221170023.452a01ca@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).