From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F8CA28EF; Thu, 22 Feb 2024 01:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708563625; cv=none; b=rk0wrZGw5sgMLM0GwwIcLeyuUGIxzSw6L5ZxJASl5rZsRA1TY5uZwC9dfOz0BIixmPs+ykw7dFS8iyNG4kdlANCvo92x7ipzE/IQbwv8iARBKcUUM7D01F+0DUPAmdJMujfpyKaXRfPBoO+UlC99enQL66znMRS7R+WXOTG7GKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708563625; c=relaxed/simple; bh=ggpfbAk/8v/uRbo53fh+Pe5sfNyqrpSgwKHDrVgb8PQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qgs1x/ig8oAq5TtvTv2CV9dll5kvw13n+/V0Svb2HBKVauPr9g4bYOh98wxUBwgqRmD+foIlB9rj0Jq0HRuZrgKf4ldoUK2gOGSf6723R0+FunUTRvNkdKktBb8SPehdkE511G1STjJyfABVInHGoVqoctrhs+RdF+xFJOhhkHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ogw8MftI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ogw8MftI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02E85C433C7; Thu, 22 Feb 2024 01:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708563625; bh=ggpfbAk/8v/uRbo53fh+Pe5sfNyqrpSgwKHDrVgb8PQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ogw8MftII1she2XJ/vthGAOx21yXJm/UADxrQwTaBYHTGurb4Bl5WhdgC01NEjlMW uPEh4cxfQg7LdyNMO9p5RAFgIlMyDeK7naLh2PZHJPKiv8Nvovbrai68h9555iGAu+ 6mNBcfnYDF8p1SJgyfNqJjOba3k8AKAPse70Psxx5vwjYx5XVtVdQ5l6j5ppSe9zq8 8x+MZWjstN3ehwaqktbqT07NythCCrcMTzbsl/BtagtPF0a7tA1CrbjUe9BAeSMs0O 4UAj+ly3OU6rAhOZ3nH6A+/LxGb7QRSq70tk9JKZRKjmbUlCuxyjwlmhjEF49fp0+M qCC/X222RBsQg== Date: Wed, 21 Feb 2024 17:00:23 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org Subject: Re: [PATCH net-next v8 08/13] netlink: specs: add ethnl PHY_GET command set Message-ID: <20240221170023.452a01ca@kernel.org> In-Reply-To: <20240220184217.3689988-9-maxime.chevallier@bootlin.com> References: <20240220184217.3689988-1-maxime.chevallier@bootlin.com> <20240220184217.3689988-9-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 20 Feb 2024 19:42:11 +0100 Maxime Chevallier wrote: > + - > + name: upstream-phy-index > + type: u32 The C define appears to be called: ETHTOOL_A_PHY_UPSTREAM_INDEX, /* u32 */ either it needs to gain the PHY_ or the spec needs to lose the phy-, otherwise C code gen gets upset: ethtool-user.c:689:10: error: =E2=80=98ETHTOOL_A_PHY_UPSTREAM_PHY_INDEX=E2= =80=99 undeclared here (not in a function); did you mean =E2=80=98ETHTOOL_A= _PHY_UPSTREAM_INDEX=E2=80=99? 689 | [ETHTOOL_A_PHY_UPSTREAM_PHY_INDEX] =3D { .name =3D "upstrea= m-phy-index", .type =3D YNL_PT_U32, }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ETHTOOL_A_PHY_UPSTREAM_INDEX Unfortunately ethtool in the in-between state where we can auto-gen user space code (or rather most of it) but the uAPI header is not auto-generated so we need to take extra care to keep things in sync :(