From: Jakub Kicinski <kuba@kernel.org>
To: kovalev@altlinux.org
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, jiri@resnulli.us, jacob.e.keller@intel.com,
johannes@sipsolutions.net, idosch@nvidia.com, horms@kernel.org,
david.lebrun@uclouvain.be, pablo@netfilter.org
Subject: Re: [PATCH net ver.2] genetlink: fix possible use-after-free and null-ptr-deref in genl_dumpit()
Date: Wed, 21 Feb 2024 17:23:09 -0800 [thread overview]
Message-ID: <20240221172309.405cc4b1@kernel.org> (raw)
In-Reply-To: <20240220102512.104452-1-kovalev@altlinux.org>
On Tue, 20 Feb 2024 13:25:12 +0300 kovalev@altlinux.org wrote:
> From: Vasiliy Kovalev <kovalev@altlinux.org>
>
> The pernet operations structure for the subsystem must be registered
> before registering the generic netlink family.
I think this one is incorrect, genetlink is what other families
register _with_. It's special. Until it opens the socket in
genl_pernet_init() nothing can reach it from user space.
We should probably add a comment saying that it's special, I get
the feeling other families ended up doing a copy & paste of genetlink..
--
pw-bot: cr
prev parent reply other threads:[~2024-02-22 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 10:25 [PATCH net ver.2] genetlink: fix possible use-after-free and null-ptr-deref in genl_dumpit() kovalev
2024-02-20 10:36 ` Pablo Neira Ayuso
2024-02-20 11:03 ` kovalev
2024-02-22 1:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221172309.405cc4b1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=david.lebrun@uclouvain.be \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kovalev@altlinux.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).