From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE93585954 for ; Wed, 21 Feb 2024 19:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708543078; cv=none; b=dSAblMlXiYKxXT6w6U4vioEGoGMhgZAEj5FRjzQQ9Yh2x8d9Ryeb+TQRgunSn9QAxjWcCftByeV8oXAQa0MQjTKEXl6lF2ObLaYJOm4XqXPohfiu7qsQmGxwRNplUTaKP2Z4r+gwrX9gTjqN/b4Deth2TpOdkVBII/kGJn7aGVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708543078; c=relaxed/simple; bh=M0FDvNe5gdx4GV6MSGP6C/r0ckrzasd1+5u7VS+D/BA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DOILaKpg2GCyo1VQRfSDGvy2okn6VITJfXievzCjCil3miJ8wN4f6xxwaGiVvV5KtyQIq1Hk6C68kaTEOIib5UAjnRfSQmWn9fGIDF6Wjj+vhDEIzLd20vpndCd5UfnGEv3UCtwYDl0UtlSvnTf2/FVxJjKoTijuvywsTlZd/YU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=ZMOoE3vL; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="ZMOoE3vL" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d746ce7d13so49117305ad.0 for ; Wed, 21 Feb 2024 11:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1708543076; x=1709147876; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xPyGME1+D4Rx5RWLjxT2dahKKgtER+x9+Q9YDDK3GZ8=; b=ZMOoE3vL80Ynwz2ejJBBIbOsOmXSZcJJ7PjQrw2q4tyf8FCHLvgVYqKJjSr+svi30K s6oxbob2r0lxbnWcTKWCcCI+tseFhnxQ6+y3LdjVHNPDbsRMMJ0HqMLLFb/BToWchOdS HqLjXCJ+3LjPj9x4yJDcDODaTCzHUCPTFuKmM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708543076; x=1709147876; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xPyGME1+D4Rx5RWLjxT2dahKKgtER+x9+Q9YDDK3GZ8=; b=SiuWwBk6PHXzDGPqnfno6hSzeiSvjCFVP7+HPeDJVfzoVEwZJXLXhAbrtT01MhzpSw scoyL/lBf0v+rGo0TeRSiXVImL7JhOrm1hMu1OnRRDb6H33FSLzsIg4ppSOxnQ3yrATC 6XyFbWs8X2wKjm91oG+nd9O+5nSO5ruARNej7AIIc3hz6OF6F+QvlC/ZjemX3a/WQot2 dZKOeHRk7S9DsX26mg3sn6QQereUkR9AfAwXa4HX22nxlJXplxG9p7F8O78VfxvAdORy 3C+Bx5h5UNTbsMe+ehK4WHzX4AjvfB1+atAbbcYXDErNM5+8GQ+rhAqMdKnNgi1vGKTJ DlBQ== X-Gm-Message-State: AOJu0YyQi5lGnbCyKntLx/XoWrzMPEeTbTfNWZCgo2rQpMmxP9wcyWjH JL2vf3wr3XwvLMvVpdSF2IQZwQeQC4b9pUtsAZkbCXog4FEfow600ID8qWeLD1FC3cgRg2Xc57K r X-Google-Smtp-Source: AGHT+IHQ43TQqS81oq7BxL4LKPXRytHQQhnbBClXNRp3eXg0/eCkjOfuROs7YtvYUWtReCcYtmoQVg== X-Received: by 2002:a17:903:1ca:b0:1db:aab5:1db5 with SMTP id e10-20020a17090301ca00b001dbaab51db5mr19811932plh.42.1708543076046; Wed, 21 Feb 2024 11:17:56 -0800 (PST) Received: from fastly.com (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id bj11-20020a170902850b00b001dc3916853csm1143816plb.73.2024.02.21.11.17.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2024 11:17:55 -0800 (PST) Date: Wed, 21 Feb 2024 11:17:53 -0800 From: Joe Damato To: Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Jesper Dangaard Brouer , Stanislav Fomichev , Amritha Nambiar , Larysa Zaremba , Lorenzo Bianconi , Tariq Toukan , Sridhar Samudrala , Alexei Starovoitov , Maciej Fijalkowski Subject: Re: [PATCH net-next 1/2] netdev-genl: Add ifname for queue and NAPI APIs Message-ID: <20240221191752.GA68788@fastly.com> References: <1708531057-67392-1-git-send-email-jdamato@fastly.com> <1708531057-67392-2-git-send-email-jdamato@fastly.com> <20240221111220.4e6b6170@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221111220.4e6b6170@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) On Wed, Feb 21, 2024 at 11:12:20AM -0800, Jakub Kicinski wrote: > On Wed, 21 Feb 2024 07:57:29 -0800 Joe Damato wrote: > > if (GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_ID) || > > GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_TYPE) || > > - GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFINDEX)) > > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFINDEX) || > > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFNAME)) > > This means user always has to provide both ifindex and ifname, > right? That's right. I'm OK with omitting this requirement, though. I feel like to your earlier point on name changes, maybe ifindex is enough as far as required params go.