From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D74E06E5E5 for ; Thu, 22 Feb 2024 18:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708627627; cv=none; b=OGrPo+LD+R2sft2nRWJDMKM7NNukU7XfECqJBCWPyvAvzUjNjR5JEfe/dr8agXWwdYBUl4dP3y9k5DQw7FUktq8A7kaXrIKN75GAN4h8gBAqMFHoLKX6Lr95NfRuH7DSylYD9rt0akk2bp/OZJIAPN/FqsdWTY/q4d3xLQ1QNUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708627627; c=relaxed/simple; bh=NwoZ/s/YB6zInacwyEad3YhKFkgtInk+ILfXRdyVvto=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lDIHlzLh2k0COtwKvozwR7MhfLC9AXjOtSzT2YXvdppYcnj6yD4YuLxA3cEZPAQSy6s4M2OhvW5EiMM/4cuknc+2lgxPs6zFV6bwo4idcOplwKhqz+uJfD/eT65n0zrC9SAAc0ijBDmkGYou9BHMIhQxi6FsxqmjxLBSL26D3dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jZnn94kL; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jZnn94kL" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6da202aa138so1385330b3a.2 for ; Thu, 22 Feb 2024 10:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708627625; x=1709232425; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W4vpO/kuwhEAbu5lyhpp3cdM+wCLzEUK+hlVl6YVNB0=; b=jZnn94kLXyYka+9eXc6AizHVEys8TFY2OiJFG7PIg2WwOoOPGz/WnjIUBC7K1XuDyA N9WXbD4i43+FAb+UXraPUYghcAZtBZ9c/hsS++vfJPdXD4DWX6Tn2LFckfPHMQVQ39OA b5jXaD5DSRAvbP8DPkBMeXcy0mMxLq472fvQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708627625; x=1709232425; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W4vpO/kuwhEAbu5lyhpp3cdM+wCLzEUK+hlVl6YVNB0=; b=eL43HcfKPeNfGQfiAqQfFnoYPXIOXM12+fULuvEFmih0kFCCIRn0NLIrWCyYF0CtnU 8zia4Ao2GlhIUhZLXFq3Ko221xSn9219AjHU1ZszU6cNoO06xua6aABYcSUsBYgD+bMB 7nWkz3nx/C6bydg39FPuJoejZHxm1s9BUspqcIKgf6wGjmfxKcKiL3uPLtoJWDZwLkFK EeqKKZ72NHOWDdPZNdcYv2V3i6JbFrBkJVid0bWYJ6MWTN3rWx20+ne8Nv1KSNreeUUs F++3epSLZX5FqA1GSWb/S2LbezKq3cRR4jpKqBzFQ/W5vna3R5Ql71zOmp9unb3d8xGZ zrww== X-Forwarded-Encrypted: i=1; AJvYcCU1/v2wWbliyYcoZx7Pca6VcgCS2Z98x4vkp/xxewyQ057fRMgSx6ych1zLaGIkXZ/qcLvylAy6XPr3QSNqyQUbiF//ilan X-Gm-Message-State: AOJu0YzhIo2MY3N9x1vJIaaqaKqq+M8DRTNc1VmR5XHarma2UafIT6P1 P6u8WUsMrVDdcf9nwOIa5NoxQGtzixCIlrMr11TQSWuoXXwjaNOcb60QgpkZKQ== X-Google-Smtp-Source: AGHT+IHgy3WwdGAsnQPmK2m2JDsitnCNDlW/VOsDIP4yBtdVhbhIse0VsuYogkkxJuuqsoNLgdNNGw== X-Received: by 2002:a05:6a00:6c95:b0:6e4:6a3f:f065 with SMTP id jc21-20020a056a006c9500b006e46a3ff065mr12647864pfb.10.1708627625231; Thu, 22 Feb 2024 10:47:05 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id s12-20020aa7828c000000b006e0651ec05csm11280323pfm.43.2024.02.22.10.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 10:47:04 -0800 (PST) Date: Thu, 22 Feb 2024 10:47:04 -0800 From: Kees Cook To: Daniel Borkmann Cc: Mark Rutland , "Gustavo A . R . Silva" , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , Haowen Bai , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Yonghong Song , Jonathan Corbet , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Joanne Koong , Yafang Shao , Kui-Feng Lee , Anton Protopopov , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v6] bpf: Replace bpf_lpm_trie_key 0-length array with flexible array Message-ID: <202402221046.020C94D@keescook> References: <20240222155612.it.533-kees@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222155612.it.533-kees@kernel.org> On Thu, Feb 22, 2024 at 07:56:15AM -0800, Kees Cook wrote: > Replace deprecated 0-length array in struct bpf_lpm_trie_key with > flexible array. Found with GCC 13: Yay! This finally passes all of CI: https://patchwork.kernel.org/project/netdevbpf/patch/20240222155612.it.533-kees@kernel.org/ -- Kees Cook