From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAC2014B825 for ; Thu, 22 Feb 2024 19:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708629724; cv=none; b=c80buOJwOmoHWWvNxVHcnm3LoENZkBxBdBwxfBvOvk9raADM+jWKE17uZRTO0RWXBB+4zihh5yNO0dt5M42miBdYoS+JPj7y2CWjjOr9O34v6NIYpSd2NpM4dz0P/MH9a/5SDcqj82utTvjwGnI1tk975yMtLmA98z1q6ICPzYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708629724; c=relaxed/simple; bh=YOFy7rDBur98HKb4T8iNwqGjLEGoqJ8uHEdBXt2njs8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uefy2qT10yYhlqobGothz/O5+fqLpv7Y/2MDohAP8BV1GepuHG2ACSPYa8bBZSVr8gNt35N33QRDdbv07ZNDikMJjs+pSKaJLMBbXhkCIh0uOEXOlCbiDGicP+0Cz8kyU5pz7Nt6CxQEAPYjn41c6IOLIESzgWGMN3ic3HvouuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CIdPvHS8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CIdPvHS8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708629721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GoW+UBQJD6ZgSdChLNCjVMHFeJ/kR7AsTe80jde9KZQ=; b=CIdPvHS8LBiw7g+2h4aX+lIKacdUg00db8CM3EQQhhmsRj81RpFLa6PHLhrN8eSwIIdBMm fQUJ3kfMDx5axDE5Yzfcj9MozRwXfg2A2HBCOw7pe/eaD7zBgXfHf7zjOngx7uZ3WE2eY9 /sydn41rYy+/CS89EGZKo0n94ld3JgU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-DU1g9I0tN0m5-F5ctAG2bA-1; Thu, 22 Feb 2024 14:22:00 -0500 X-MC-Unique: DU1g9I0tN0m5-F5ctAG2bA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4125edd9c6bso284045e9.2 for ; Thu, 22 Feb 2024 11:22:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708629719; x=1709234519; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GoW+UBQJD6ZgSdChLNCjVMHFeJ/kR7AsTe80jde9KZQ=; b=Z/c8KKFmQ1c3CFMXuiGaoNQYsH94Yl0+Jxr+qp1rhBQZoNhWJNArd6VMRfDCc+lHPz DJlNQsoy3yvQF4GwJ2yLrXF70kTFoMhosz55/LiYNqbVYLB2/qiArSmM1eH5lMLyqO8B qyKmOD1WDljz//32aeNtJFxXLuk7yL14r8FIXv9CnrsR4K5pkkQyjTcrLiilEKUt/yQK GKzqP105/4T/DSUAugB/8Q51oRs4LCqNkikTJeXlLe7F8ttcFOaWTe/bEzRypemPQ+6S fKjwS1tvYeQa4TbrOM9/+znczEIEnabMjzSWrJVYRZ3JuwYffaW/IkwtDAGnwlTXy/2j 362Q== X-Forwarded-Encrypted: i=1; AJvYcCXIQilrYOtjOT4q8BTRnXxjQ2WIXWGDRGaAldlnupBO81JtXS4KAJFT8QREXItsS++UWGF1Oc6JtYJDEbMPX0ilkajwB7sJ X-Gm-Message-State: AOJu0Yx1hP1iu/WyqQ0zRlKBU8jyD0K8zIB1cjqpJYI5doy1Mgc1gHX0 su2xplXTlAHe6CfBxQ2Ibl/KJgF8kg7NKHQw8QxOP3cndPnhbMtK7v1XMzReROZWCCGjnsJfFuv cH5/hlTAYsPf0yeSVOsqddWc0SP+g+dQsuA9JFGgMIvRYbmZ55fhJrQ== X-Received: by 2002:a5d:4a42:0:b0:33d:6fd8:90d3 with SMTP id v2-20020a5d4a42000000b0033d6fd890d3mr80479wrs.4.1708629719230; Thu, 22 Feb 2024 11:21:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyAsNHbNiywW9uYcePA/nsah0M+iug3QdVHUBuhKgxM3+lUOSbNSmQdjj9XJdRV2NVji0Wbw== X-Received: by 2002:a5d:4a42:0:b0:33d:6fd8:90d3 with SMTP id v2-20020a5d4a42000000b0033d6fd890d3mr80467wrs.4.1708629718894; Thu, 22 Feb 2024 11:21:58 -0800 (PST) Received: from redhat.com ([172.93.237.99]) by smtp.gmail.com with ESMTPSA id x1-20020a5d4441000000b0033d8871acdfsm3865273wrr.69.2024.02.22.11.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 11:21:58 -0800 (PST) Date: Thu, 22 Feb 2024 14:21:50 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Maxime Coquelin , Shannon Nelson , xuanzhuo@linux.alibaba.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net Subject: Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop Message-ID: <20240222142056-mutt-send-email-mst@kernel.org> References: <20230720170001-mutt-send-email-mst@kernel.org> <263a5ad7-1189-3be3-70de-c38a685bebe0@redhat.com> <20230721104445-mutt-send-email-mst@kernel.org> <6278a4aa-8901-b0e3-342f-5753a4bf32af@redhat.com> <20230721110925-mutt-send-email-mst@kernel.org> <20230723053441-mutt-send-email-mst@kernel.org> <20230724031732-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jul 25, 2023 at 11:03:11AM +0800, Jason Wang wrote: > On Mon, Jul 24, 2023 at 3:18 PM Michael S. Tsirkin wrote: > > > > On Mon, Jul 24, 2023 at 02:52:49PM +0800, Jason Wang wrote: > > > On Mon, Jul 24, 2023 at 2:46 PM Michael S. Tsirkin wrote: > > > > > > > > On Fri, Jul 21, 2023 at 10:18:03PM +0200, Maxime Coquelin wrote: > > > > > > > > > > > > > > > On 7/21/23 17:10, Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 21, 2023 at 04:58:04PM +0200, Maxime Coquelin wrote: > > > > > > > > > > > > > > > > > > > > > On 7/21/23 16:45, Michael S. Tsirkin wrote: > > > > > > > > On Fri, Jul 21, 2023 at 04:37:00PM +0200, Maxime Coquelin wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > On 7/20/23 23:02, Michael S. Tsirkin wrote: > > > > > > > > > > On Thu, Jul 20, 2023 at 01:26:20PM -0700, Shannon Nelson wrote: > > > > > > > > > > > On 7/20/23 1:38 AM, Jason Wang wrote: > > > > > > > > > > > > > > > > > > > > > > > > Adding cond_resched() to the command waiting loop for a better > > > > > > > > > > > > co-operation with the scheduler. This allows to give CPU a breath to > > > > > > > > > > > > run other task(workqueue) instead of busy looping when preemption is > > > > > > > > > > > > not allowed on a device whose CVQ might be slow. > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Jason Wang > > > > > > > > > > > > > > > > > > > > > > This still leaves hung processes, but at least it doesn't pin the CPU any > > > > > > > > > > > more. Thanks. > > > > > > > > > > > Reviewed-by: Shannon Nelson > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I'd like to see a full solution > > > > > > > > > > 1- block until interrupt > > > > > > > > > > > > > > > > > > Would it make sense to also have a timeout? > > > > > > > > > And when timeout expires, set FAILED bit in device status? > > > > > > > > > > > > > > > > virtio spec does not set any limits on the timing of vq > > > > > > > > processing. > > > > > > > > > > > > > > Indeed, but I thought the driver could decide it is too long for it. > > > > > > > > > > > > > > The issue is we keep waiting with rtnl locked, it can quickly make the > > > > > > > system unusable. > > > > > > > > > > > > if this is a problem we should find a way not to keep rtnl > > > > > > locked indefinitely. > > > > > > > > > > From the tests I have done, I think it is. With OVS, a reconfiguration is > > > > > performed when the VDUSE device is added, and when a MLX5 device is > > > > > in the same bridge, it ends up doing an ioctl() that tries to take the > > > > > rtnl lock. In this configuration, it is not possible to kill OVS because > > > > > it is stuck trying to acquire rtnl lock for mlx5 that is held by virtio- > > > > > net. > > > > > > > > So for sure, we can queue up the work and process it later. > > > > The somewhat tricky part is limiting the memory consumption. > > > > > > And it needs to sync with rtnl somehow, e.g device unregistering which > > > seems not easy. > > > > > > Thanks > > > > since when does device unregister need to send cvq commands? > > It doesn't do this now. But if we don't process the work under rtnl, > we need to synchronize with device unregistering. > > Thanks But what's not easy about it? > > > > > > > > > > > > > > > > > > > > > > > > > > 2- still handle surprise removal correctly by waking in that case > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > > > drivers/net/virtio_net.c | 4 +++- > > > > > > > > > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > > > > > > > > > > > index 9f3b1d6ac33d..e7533f29b219 100644 > > > > > > > > > > > > --- a/drivers/net/virtio_net.c > > > > > > > > > > > > +++ b/drivers/net/virtio_net.c > > > > > > > > > > > > @@ -2314,8 +2314,10 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd, > > > > > > > > > > > > * into the hypervisor, so the request should be handled immediately. > > > > > > > > > > > > */ > > > > > > > > > > > > while (!virtqueue_get_buf(vi->cvq, &tmp) && > > > > > > > > > > > > - !virtqueue_is_broken(vi->cvq)) > > > > > > > > > > > > + !virtqueue_is_broken(vi->cvq)) { > > > > > > > > > > > > + cond_resched(); > > > > > > > > > > > > cpu_relax(); > > > > > > > > > > > > + } > > > > > > > > > > > > > > > > > > > > > > > > return vi->ctrl->status == VIRTIO_NET_OK; > > > > > > > > > > > > } > > > > > > > > > > > > -- > > > > > > > > > > > > 2.39.3 > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > > Virtualization mailing list > > > > > > > > > > > > Virtualization@lists.linux-foundation.org > > > > > > > > > > > > https://lists.linuxfoundation.org/mailman/listinfo/virtualization > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >