From: Jakub Kicinski <kuba@kernel.org>
To: "Nambiar, Amritha" <amritha.nambiar@intel.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>, <danielj@nvidia.com>,
<mst@redhat.com>, <michael.chan@broadcom.com>
Subject: Re: [RFC net-next 3/3] eth: bnxt: support per-queue statistics
Date: Thu, 22 Feb 2024 17:33:45 -0800 [thread overview]
Message-ID: <20240222173345.518d32fc@kernel.org> (raw)
In-Reply-To: <7d89adc1-2d2d-4681-b6a8-166221639997@intel.com>
On Thu, 22 Feb 2024 16:29:15 -0800 Nambiar, Amritha wrote:
> So, with projection: 0, the counters would remain unchanged after
> reconfiguration ?
Yes, device level stats (projection 0) should maintain history across
reconfig - some form of explicit ethtool --reset $ifc or devlink reload
may reset them but not changing ring count, attaching XDP or alike.
Queue level stats (projection 1 or "queue") can be reset when queue is
recreated, for some drivers doesn't matter but probably better if
reconfigs reset them.
I mentioned this in a kdoc comment on struct netdev_stat_ops - the
justification for different reset regimes is (1) to make driver
implementations easier but also (2) because the main (only?) known use
case for queue stats is to check if traffic is balanced. If we run with
4 queues and then bump to 8, and stats are not reset, the first 4 queues
will have much higher counters. So it's hard to tell from a snapshot if
traffic is balanced or not.
next prev parent reply other threads:[~2024-02-23 1:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 22:36 [RFC net-next 0/3] netdev: add per-queue statistics Jakub Kicinski
2024-02-22 22:36 ` [RFC net-next 1/3] " Jakub Kicinski
2024-02-23 0:23 ` Nambiar, Amritha
2024-02-23 1:37 ` Jakub Kicinski
2024-02-23 20:40 ` Nambiar, Amritha
2024-02-23 0:29 ` Nambiar, Amritha
2024-02-23 1:44 ` Jakub Kicinski
2024-02-23 4:32 ` Stanislav Fomichev
2024-02-23 9:22 ` Vadim Fedorenko
2024-02-23 20:51 ` Nambiar, Amritha
2024-02-24 0:13 ` Jakub Kicinski
2024-02-26 19:42 ` Nambiar, Amritha
2024-02-22 22:36 ` [RFC net-next 2/3] netdev: add queue stat for alloc failures Jakub Kicinski
2024-02-22 22:36 ` [RFC net-next 3/3] eth: bnxt: support per-queue statistics Jakub Kicinski
2024-02-23 0:29 ` Nambiar, Amritha
2024-02-23 1:33 ` Jakub Kicinski [this message]
2024-02-23 20:42 ` Nambiar, Amritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222173345.518d32fc@kernel.org \
--to=kuba@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).