From: Jakub Kicinski <kuba@kernel.org>
To: "Nambiar, Amritha" <amritha.nambiar@intel.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>, <danielj@nvidia.com>,
<mst@redhat.com>, <michael.chan@broadcom.com>
Subject: Re: [RFC net-next 1/3] netdev: add per-queue statistics
Date: Thu, 22 Feb 2024 17:37:03 -0800 [thread overview]
Message-ID: <20240222173703.08c442e9@kernel.org> (raw)
In-Reply-To: <835c44da-598b-4c33-8a4d-14e946a8f451@intel.com>
On Thu, 22 Feb 2024 16:23:57 -0800 Nambiar, Amritha wrote:
> > +int netdev_nl_stats_get_dumpit(struct sk_buff *skb,
> > + struct netlink_callback *cb)
> > +{
> > + struct netdev_nl_dump_ctx *ctx = netdev_dump_ctx(cb);
> > + const struct genl_info *info = genl_info_dump(cb);
> > + enum netdev_stats_projection projection;
> > + struct net *net = sock_net(skb->sk);
> > + struct net_device *netdev;
> > + int err = 0;
> > +
> > + projection = NETDEV_STATS_PROJECTION_NETDEV;
> > + if (info->attrs[NETDEV_A_STATS_PROJECTION])
> > + projection =
> > + nla_get_uint(info->attrs[NETDEV_A_STATS_PROJECTION]);
> > +
> > + rtnl_lock();
>
> Could we also add filtered-dump for a user provided ifindex ?
Definitely, wasn't sure if that's a pre-requisite for merging,
or we can leave it on the "netdev ToDo sheet" as a learning task
for someone. Opinions welcome..
next prev parent reply other threads:[~2024-02-23 1:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 22:36 [RFC net-next 0/3] netdev: add per-queue statistics Jakub Kicinski
2024-02-22 22:36 ` [RFC net-next 1/3] " Jakub Kicinski
2024-02-23 0:23 ` Nambiar, Amritha
2024-02-23 1:37 ` Jakub Kicinski [this message]
2024-02-23 20:40 ` Nambiar, Amritha
2024-02-23 0:29 ` Nambiar, Amritha
2024-02-23 1:44 ` Jakub Kicinski
2024-02-23 4:32 ` Stanislav Fomichev
2024-02-23 9:22 ` Vadim Fedorenko
2024-02-23 20:51 ` Nambiar, Amritha
2024-02-24 0:13 ` Jakub Kicinski
2024-02-26 19:42 ` Nambiar, Amritha
2024-02-22 22:36 ` [RFC net-next 2/3] netdev: add queue stat for alloc failures Jakub Kicinski
2024-02-22 22:36 ` [RFC net-next 3/3] eth: bnxt: support per-queue statistics Jakub Kicinski
2024-02-23 0:29 ` Nambiar, Amritha
2024-02-23 1:33 ` Jakub Kicinski
2024-02-23 20:42 ` Nambiar, Amritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222173703.08c442e9@kernel.org \
--to=kuba@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).