[PATCH net-next] net: stmmac: fix typo in comment

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH net-next] net: stmmac: fix typo in comment
@ 2024-02-21 10:35 Yanteng Si
  2024-02-21 12:33 ` Serge Semin
  2024-02-23  3:12 ` Jakub Kicinski
  0 siblings, 2 replies; 8+ messages in thread
From: Yanteng Si @ 2024-02-21 10:35 UTC (permalink / raw)
  To: andrew, alexandre.torgue
  Cc: joabreu, davem, horms, fancer.lancer, netdev, Yanteng Si

This is just a trivial fix for a typo in a comment, no functional
changes.

Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")
Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
---
In fact, it was discovered during the review of the Loongson
driver patch.:)

 drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
index 358e7dcb6a9a..9d640ba5c323 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
@@ -92,7 +92,7 @@
 #define DMA_TBS_FTOV			BIT(0)
 #define DMA_TBS_DEF_FTOS		(DMA_TBS_FTOS | DMA_TBS_FTOV)
 
-/* Following DMA defines are chanels oriented */
+/* Following DMA defines are channels oriented */
 #define DMA_CHAN_BASE_ADDR		0x00001100
 #define DMA_CHAN_BASE_OFFSET		0x80
 
-- 
2.31.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net: stmmac: fix typo in comment
  2024-02-21 10:35 [PATCH net-next] net: stmmac: fix typo in comment Yanteng Si
@ 2024-02-21 12:33 ` Serge Semin
  2024-02-23  3:12 ` Jakub Kicinski
  1 sibling, 0 replies; 8+ messages in thread
From: Serge Semin @ 2024-02-21 12:33 UTC (permalink / raw)
  To: Yanteng Si; +Cc: andrew, alexandre.torgue, joabreu, davem, horms, netdev

Hi Yanteng

On Wed, Feb 21, 2024 at 06:35:14PM +0800, Yanteng Si wrote:
> This is just a trivial fix for a typo in a comment, no functional
> changes.
> 
> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")
> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

Thanks for submitting the patch.
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>

-Serge(y)

> ---
> In fact, it was discovered during the review of the Loongson
> driver patch.:)
> 
>  drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> index 358e7dcb6a9a..9d640ba5c323 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> @@ -92,7 +92,7 @@
>  #define DMA_TBS_FTOV			BIT(0)
>  #define DMA_TBS_DEF_FTOS		(DMA_TBS_FTOS | DMA_TBS_FTOV)
>  
> -/* Following DMA defines are chanels oriented */
> +/* Following DMA defines are channels oriented */
>  #define DMA_CHAN_BASE_ADDR		0x00001100
>  #define DMA_CHAN_BASE_OFFSET		0x80
>  
> -- 
> 2.31.4
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net: stmmac: fix typo in comment
  2024-02-21 10:35 [PATCH net-next] net: stmmac: fix typo in comment Yanteng Si
  2024-02-21 12:33 ` Serge Semin
@ 2024-02-23  3:12 ` Jakub Kicinski
  2024-02-28 10:45   ` Yanteng Si
  2024-02-28 11:19   ` Yanteng Si
  1 sibling, 2 replies; 8+ messages in thread
From: Jakub Kicinski @ 2024-02-23  3:12 UTC (permalink / raw)
  To: Yanteng Si
  Cc: andrew, alexandre.torgue, joabreu, davem, horms, fancer.lancer,
	netdev

On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote:
> This is just a trivial fix for a typo in a comment, no functional
> changes.
> 
> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")

Fixes is reserved for functional bugs, let's leave it out
for a typo correction.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> index 358e7dcb6a9a..9d640ba5c323 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> @@ -92,7 +92,7 @@
>  #define DMA_TBS_FTOV			BIT(0)
>  #define DMA_TBS_DEF_FTOS		(DMA_TBS_FTOS | DMA_TBS_FTOV)
>  
> -/* Following DMA defines are chanels oriented */
> +/* Following DMA defines are channels oriented */

I'm not a native speaker but I'd spell it "... are channel-oriented"
With a hyphen, channel not channels.

>  #define DMA_CHAN_BASE_ADDR		0x00001100
>  #define DMA_CHAN_BASE_OFFSET		0x80
>  


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net: stmmac: fix typo in comment
  2024-02-23  3:12 ` Jakub Kicinski
@ 2024-02-28 10:45   ` Yanteng Si
  2024-02-28 11:19   ` Yanteng Si
  1 sibling, 0 replies; 8+ messages in thread
From: Yanteng Si @ 2024-02-28 10:45 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: andrew, alexandre.torgue, joabreu, davem, horms, fancer.lancer,
	netdev


在 2024/2/23 11:12, Jakub Kicinski 写道:
> On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote:
>> This is just a trivial fix for a typo in a comment, no functional
>> changes.
>>
>> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")
> Fixes is reserved for functional bugs, let's leave it out
> for a typo correction.

OK!

I will remove it.

Thanks,

Yanteng

>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> index 358e7dcb6a9a..9d640ba5c323 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> @@ -92,7 +92,7 @@
>>   #define DMA_TBS_FTOV			BIT(0)
>>   #define DMA_TBS_DEF_FTOS		(DMA_TBS_FTOS | DMA_TBS_FTOV)
>>   
>> -/* Following DMA defines are chanels oriented */
>> +/* Following DMA defines are channels oriented */
> I'm not a native speaker but I'd spell it "... are channel-oriented"
> With a hyphen, channel not channels.
>
>>   #define DMA_CHAN_BASE_ADDR		0x00001100
>>   #define DMA_CHAN_BASE_OFFSET		0x80
>>   


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net: stmmac: fix typo in comment
  2024-02-23  3:12 ` Jakub Kicinski
  2024-02-28 10:45   ` Yanteng Si
@ 2024-02-28 11:19   ` Yanteng Si
  1 sibling, 0 replies; 8+ messages in thread
From: Yanteng Si @ 2024-02-28 11:19 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: andrew, alexandre.torgue, joabreu, davem, horms, fancer.lancer,
	netdev


在 2024/2/23 11:12, Jakub Kicinski 写道:
> On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote:
>> This is just a trivial fix for a typo in a comment, no functional
>> changes.
>>
>> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")
> Fixes is reserved for functional bugs, let's leave it out
> for a typo correction.
>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> index 358e7dcb6a9a..9d640ba5c323 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
>> @@ -92,7 +92,7 @@
>>   #define DMA_TBS_FTOV			BIT(0)
>>   #define DMA_TBS_DEF_FTOS		(DMA_TBS_FTOS | DMA_TBS_FTOV)
>>   
>> -/* Following DMA defines are chanels oriented */
>> +/* Following DMA defines are channels oriented */
> I'm not a native speaker but I'd spell it "... are channel-oriented"
> With a hyphen, channel not channels.

OK.


Thanks,

Yanteng

>>   #define DMA_CHAN_BASE_ADDR		0x00001100
>>   #define DMA_CHAN_BASE_OFFSET		0x80
>>   


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH net-next] net: stmmac: fix typo in comment
@ 2023-10-10 17:24 Johannes Zink
  2023-10-12 15:44 ` Simon Horman
  2023-10-13 10:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 8+ messages in thread
From: Johannes Zink @ 2023-10-10 17:24 UTC (permalink / raw)
  To: alexandre.torgue, joabreu, davem, edumazet, kuba, pabeni,
	mcoquelin.stm32, richardcochran
  Cc: patchwork-jzi, netdev, linux-stm32, linux-arm-kernel,
	linux-kernel, kernel, Johannes Zink

This is just a trivial fix for a typo in a comment, no functional
changes.

Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
index 60b6b4a180d7..a5320c9556b5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
@@ -81,7 +81,7 @@ static int stmmac_adjust_time(struct ptp_clock_info *ptp, s64 delta)
 	stmmac_adjust_systime(priv, priv->ptpaddr, sec, nsec, neg_adj, xmac);
 	write_unlock_irqrestore(&priv->ptp_lock, flags);
 
-	/* Caculate new basetime and re-configured EST after PTP time adjust. */
+	/* Calculate new basetime and re-configured EST after PTP time adjust. */
 	if (est_rst) {
 		struct timespec64 current_time, time;
 		ktime_t current_time_ns, basetime;
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net: stmmac: fix typo in comment
  2023-10-10 17:24 Johannes Zink
@ 2023-10-12 15:44 ` Simon Horman
  2023-10-13 10:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 8+ messages in thread
From: Simon Horman @ 2023-10-12 15:44 UTC (permalink / raw)
  To: Johannes Zink
  Cc: alexandre.torgue, joabreu, davem, edumazet, kuba, pabeni,
	mcoquelin.stm32, richardcochran, patchwork-jzi, netdev,
	linux-stm32, linux-arm-kernel, linux-kernel, kernel

On Tue, Oct 10, 2023 at 07:24:15PM +0200, Johannes Zink wrote:
> This is just a trivial fix for a typo in a comment, no functional
> changes.
> 
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>

Thanks,

I checked and codespell doesn't flag any other spelling errors in this file.

Reviewed-by: Simon Horman <horms@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net: stmmac: fix typo in comment
  2023-10-10 17:24 Johannes Zink
  2023-10-12 15:44 ` Simon Horman
@ 2023-10-13 10:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-13 10:30 UTC (permalink / raw)
  To: Johannes Zink
  Cc: alexandre.torgue, joabreu, davem, edumazet, kuba, pabeni,
	mcoquelin.stm32, richardcochran, patchwork-jzi, netdev,
	linux-stm32, linux-arm-kernel, linux-kernel, kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue, 10 Oct 2023 19:24:15 +0200 you wrote:
> This is just a trivial fix for a typo in a comment, no functional
> changes.
> 
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] net: stmmac: fix typo in comment
    https://git.kernel.org/netdev/net-next/c/895359b8c1e7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-02-28 11:19 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-21 10:35 [PATCH net-next] net: stmmac: fix typo in comment Yanteng Si
2024-02-21 12:33 ` Serge Semin
2024-02-23  3:12 ` Jakub Kicinski
2024-02-28 10:45   ` Yanteng Si
2024-02-28 11:19   ` Yanteng Si
  -- strict thread matches above, loose matches on Subject: below --
2023-10-10 17:24 Johannes Zink
2023-10-12 15:44 ` Simon Horman
2023-10-13 10:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).