From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
horms@kernel.org, przemyslaw.kitszel@intel.com,
Lukasz Czapnik <lukasz.czapnik@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param
Date: Fri, 23 Feb 2024 06:27:57 -0800 [thread overview]
Message-ID: <20240223062757.788e686d@kernel.org> (raw)
In-Reply-To: <ZdhpHSWIbcTE-LQh@nanopsycho>
On Fri, 23 Feb 2024 10:45:01 +0100 Jiri Pirko wrote:
>> Jiri, I'm not aware of any other devices with this sort of trade off.
>> We shouldn't add the param if either:
>> - this can be changed dynamically as user instantiates rate limiters;
>> - we know other devices have similar needs.
>> If neither of those is true, param seems fine to me..
>
> Where is this policy documented? If not, could you please? Let's make
> this policy clear for now and for the future.
Because you think it's good as a policy or because not so much?
Both of the points are a judgment call, at least from upstream
perspective since we're working with very limited information.
So enshrining this as a "policy" is not very practical.
Do you recall any specific param that got rejected from mlx5?
Y'all were allowed to add the eq sizing params, which I think
is not going to be mlx5-only for long. Otherwise I only remember
cases where I'd try to push people to use the resource API, which
IMO is better for setting limits and delegating resources.
next prev parent reply other threads:[~2024-02-23 14:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 10:05 [Intel-wired-lan] [PATCH iwl-next v4 0/5] ice: Support 5 layer Tx scheduler topology Mateusz Polchlopek
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v1 1/5] ice: Support 5 layer topology Mateusz Polchlopek
2024-02-19 10:16 ` Mateusz Polchlopek
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v4 2/5] ice: Adjust the VSI/Aggregator layers Mateusz Polchlopek
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v4 3/5] ice: Enable switching default Tx scheduler topology Mateusz Polchlopek
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param Mateusz Polchlopek
2024-02-19 12:37 ` Jiri Pirko
2024-02-19 13:33 ` Przemek Kitszel
2024-02-19 17:15 ` Jiri Pirko
2024-02-21 23:38 ` Jakub Kicinski
2024-02-22 13:25 ` Mateusz Polchlopek
2024-02-22 23:07 ` Jakub Kicinski
2024-02-23 9:45 ` Jiri Pirko
2024-02-23 14:27 ` Jakub Kicinski [this message]
2024-02-25 7:18 ` Jiri Pirko
2024-02-27 2:37 ` Jakub Kicinski
2024-02-27 12:17 ` Jiri Pirko
2024-02-27 13:05 ` Przemek Kitszel
2024-02-27 15:39 ` Jiri Pirko
2024-02-27 15:41 ` Andrew Lunn
2024-02-27 16:04 ` Jiri Pirko
2024-02-27 20:38 ` Andrew Lunn
2024-02-19 10:05 ` [Intel-wired-lan] [PATCH iwl-next v4 5/5] ice: Document tx_scheduling_layers parameter Mateusz Polchlopek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223062757.788e686d@kernel.org \
--to=kuba@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=lukasz.czapnik@intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).