From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Jose Abreu <joabreu@synopsys.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
openbmc@lists.ozlabs.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: pcs: xpcs: Explicitly return error on caps validation
Date: Fri, 23 Feb 2024 10:56:26 +0100 [thread overview]
Message-ID: <20240223105626.71b2bcb2@device-28.home> (raw)
In-Reply-To: <20240222175843.26919-5-fancer.lancer@gmail.com>
Hello Serge,
On Thu, 22 Feb 2024 20:58:23 +0300
Serge Semin <fancer.lancer@gmail.com> wrote:
> If an unsupported interface is passed to the PCS validation callback there
> is no need in further link-modes calculations since the resultant array
> will be initialized with zeros which will be perceived by the phylink
> subsystem as error anyway (see phylink_validate_mac_and_pcs()). Instead
> let's explicitly return the -EINVAL error to inform the caller about the
> unsupported interface as it's done in the rest of the pcs_validate
> callbacks.
>
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
This looks good to me,
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
next prev parent reply other threads:[~2024-02-23 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 17:58 [PATCH net-next v2 0/4] net: pcs: xpcs: Cleanups before adding MMIO dev support Serge Semin
2024-02-22 17:58 ` [PATCH net-next v2 1/4] net: pcs: xpcs: Drop sentinel entry from 2500basex ifaces list Serge Semin
2024-02-22 17:58 ` [PATCH net-next v2 2/4] net: pcs: xpcs: Drop redundant workqueue.h include directive Serge Semin
2024-02-22 17:58 ` [PATCH net-next v2 3/4] net: pcs: xpcs: Return EINVAL in the internal methods Serge Semin
2024-02-22 17:58 ` [PATCH net-next v2 4/4] net: pcs: xpcs: Explicitly return error on caps validation Serge Semin
2024-02-23 9:56 ` Maxime Chevallier [this message]
2024-02-26 13:10 ` [PATCH net-next v2 0/4] net: pcs: xpcs: Cleanups before adding MMIO dev support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223105626.71b2bcb2@device-28.home \
--to=maxime.chevallier@bootlin.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jiawenwu@trustnetic.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).