From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ABDD14B835; Fri, 23 Feb 2024 11:16:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708686989; cv=none; b=rD9cudBRjttmh3cCEdUoGUDDOIaXFGmcKo3aTNzGiChSvH2x+8+/OaNsuLRIkNZKk0e1JdOOdTQh2ePRh2S0bckx4poYLcVjZnmbM4vB7GL9wuW8Ok22MkRgBG3+FKo5A0ejByXmyfxtwS+cq8tkCfmXSLXgWx9XEvwPdGWSob4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708686989; c=relaxed/simple; bh=bCP9xIHaRBY6slhXkEczq0iwAfBBoyIZlUPlQCFQ93o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W7KboKzNl1tCyVZuIDsJCc6raNO+21YkZZUogkwMRi21dEPMPgLiKSEwfeRBZHV9IlHgrgi1peGIX2o3C9ATlZlIO6kv++ie7IyIw/3TJ6BYLreObba3+cpi4P07Qdyokdt4YjS4bc6oCyTbHyDw0ZwH2NIslEt8zVDfLYku4wY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=N+4llCPZ; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="N+4llCPZ" Received: by mail.gandi.net (Postfix) with ESMTPSA id C1B1520005; Fri, 23 Feb 2024 11:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708686984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bCP9xIHaRBY6slhXkEczq0iwAfBBoyIZlUPlQCFQ93o=; b=N+4llCPZevgTvBggZq8lo7lMJfaFDrjsN6nOnM/ydnQgxhWC8rE+xxvEJjjJcQCo+FpJzt TWR0vQvsOJU6KVR8Vh1QvcrzAYfpzBVOJis1Cm2JHDmd61mXcjEh0D/jQHxam+d0xoQhuh M6k04k+EmUf4dQhiumN5C4hjn0ILWLr12S5bzUampCnMdtdPYocFdtFoFkM4bfkLFWxRkZ iVxApVsJUQ+/jP8HtPbKsspxH1GxLRJAMJq+p7J5t5p7s1kywwoe5ykknRVxNhpL1M5Ff6 yd6zlqC0ugVd0NmAlwmDX78yIm9X2YGWQ+UBQKYliBor9uLdY+ftZKwCI35TJQ== Date: Fri, 23 Feb 2024 12:16:22 +0100 From: Maxime Chevallier To: =?UTF-8?B?SsOpcsOpbWll?= Dautheribes Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Heiner Kallweit , Russell King , Andrew Davis , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , =?UTF-8?B?TWlxdcOobA==?= Raynal , Yen-Mei Goh Subject: Re: [PATCH net-next 2/3] net: phy: dp83826: Add support for phy-mode configuration Message-ID: <20240223121622.6bd9e3b1@device-28.home> In-Reply-To: <20240222103117.526955-3-jeremie.dautheribes@bootlin.com> References: <20240222103117.526955-1-jeremie.dautheribes@bootlin.com> <20240222103117.526955-3-jeremie.dautheribes@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: maxime.chevallier@bootlin.com Hello J=C3=A9r=C3=A9mie, On Thu, 22 Feb 2024 11:31:16 +0100 J=C3=A9r=C3=A9mie Dautheribes wrote: > The TI DP83826 PHY can operate in either MII mode or RMII mode. > By default, it is configured by straps. > It can also be configured by writing to the bit 5 of register 0x17 - RMII > and Status Register (RCSR). >=20 > When phydev->interface is rmii, rmii mode must be enabled, otherwise > mii mode must be set. > This prevents misconfiguration of hw straps. >=20 > Signed-off-by: J=C3=A9r=C3=A9mie Dautheribes This looks good to me, Reviewed-by: Maxime Chevallier