From: Kees Cook <keescook@chromium.org>
To: Finn Thain <fthain@linux-m68k.org>
Cc: Justin Stitt <justinstitt@google.com>,
Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Ariel Elior <aelior@marvell.com>,
Manish Chopra <manishc@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Saurav Kashyap <skashyap@marvell.com>,
Javed Hasan <jhasan@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Nilesh Javali <njavali@marvell.com>,
Manish Rangankar <mrangankar@marvell.com>,
Don Brace <don.brace@microchip.com>,
mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
MPT-FusionLinux.pdl@broadcom.com, netdev@vger.kernel.org,
storagedev@microchip.com
Subject: Re: [PATCH 1/7] scsi: mpi3mr: replace deprecated strncpy with strscpy
Date: Fri, 23 Feb 2024 16:04:21 -0800 [thread overview]
Message-ID: <202402231603.152B165@keescook> (raw)
In-Reply-To: <512c1700-b333-8aea-f19b-707523ac3a6e@linux-m68k.org>
On Sat, Feb 24, 2024 at 10:58:07AM +1100, Finn Thain wrote:
>
> On Fri, 23 Feb 2024, Justin Stitt wrote:
>
> > Really, there's no bug with the current code.
>
> If (hypothetically) you needed to reduce stack size, just copy the char
> pointer instead of copying the chars onto the stack.
>
> If (hypothetically) strncpy() was banned altogether (rather than merely
> deprecated) I would do the same -- but I'm not the maintainer.
I'd agree. This can just be using:
const char *personality;
...
personality = "RAID";
etc
--
Kees Cook
next prev parent reply other threads:[~2024-02-24 0:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 22:23 [PATCH 0/7] scsi: replace deprecated strncpy Justin Stitt
2024-02-23 22:23 ` [PATCH 1/7] scsi: mpi3mr: replace deprecated strncpy with strscpy Justin Stitt
2024-02-23 23:58 ` Finn Thain
2024-02-24 0:04 ` Kees Cook [this message]
2024-02-23 22:23 ` [PATCH 2/7] scsi: mpt3sas: " Justin Stitt
2024-02-24 0:05 ` Kees Cook
2024-02-23 22:23 ` [PATCH 3/7] scsi: qedf: " Justin Stitt
2024-02-24 0:09 ` Kees Cook
2024-02-23 22:23 ` [PATCH 4/7] scsi: qla4xxx: " Justin Stitt
2024-02-24 0:23 ` Kees Cook
2024-02-23 22:23 ` [PATCH 5/7] scsi: devinfo: replace strncpy and manual pad Justin Stitt
2024-02-24 0:26 ` Kees Cook
2024-02-23 22:23 ` [PATCH 6/7] scsi: smartpqi: replace deprecated strncpy with strscpy Justin Stitt
2024-02-24 0:27 ` Kees Cook
2024-02-23 22:23 ` [PATCH 7/7] scsi: wd33c93: " Justin Stitt
2024-02-23 23:44 ` Finn Thain
2024-02-24 0:01 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402231603.152B165@keescook \
--to=keescook@chromium.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=don.brace@microchip.com \
--cc=edumazet@google.com \
--cc=fthain@linux-m68k.org \
--cc=jejb@linux.ibm.com \
--cc=jhasan@marvell.com \
--cc=justinstitt@google.com \
--cc=kashyap.desai@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=martin.petersen@oracle.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=mrangankar@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=pabeni@redhat.com \
--cc=sathya.prakash@broadcom.com \
--cc=skashyap@marvell.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=storagedev@microchip.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).