From: Jakub Kicinski <kuba@kernel.org>
To: Jakub Raczynski <j.raczynski@samsung.com>
Cc: netdev@vger.kernel.org, alexandre.torgue@foss.st.com,
joabreu@synopsys.com
Subject: Re: [PATCH] stmmac: Clear variable when destroying workqueue
Date: Fri, 23 Feb 2024 16:32:51 -0800 [thread overview]
Message-ID: <20240223163251.49bd1870@kernel.org> (raw)
In-Reply-To: <20240221143233.54350-1-j.raczynski@samsung.com>
On Wed, 21 Feb 2024 15:32:33 +0100 Jakub Raczynski wrote:
> Currently when suspending driver and stopping workqueue it is checked whether
> workqueue is not NULL and if so, it is destroyed.
> Function destroy_workqueue() does drain queue and does clear variable, but
> it does not set workqueue variable to NULL. This can cause kernel/module
> panic if code attempts to clear workqueue that was not initialized.
Is there no risk that we'll try to queue_work() on the uninitialized
workqueue? I wonder if we should also set __FPE_REMOVING when the
queue allocation fails, just to make sure we never try to queue?
Please repost with a Fixes tag added (pointing to oldest commit where
the problem may happen), and with [PATCH net v2] as the subject tag.
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-24 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240221143239eucas1p259ca215d24490cd7fc073a6c3c35693b@eucas1p2.samsung.com>
2024-02-21 14:32 ` [PATCH] stmmac: Clear variable when destroying workqueue Jakub Raczynski
2024-02-24 0:32 ` Jakub Kicinski [this message]
2024-02-26 11:06 ` Jakub Raczynski
2024-02-26 14:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223163251.49bd1870@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=j.raczynski@samsung.com \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).