From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Allison Henderson <allison.henderson@oracle.com>
Cc: Sowmini Varadhan <sowmini.varadhan@oracle.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <rds-devel@oss.oracle.com>
Subject: [PATCH v1 net 0/2] rds: Fix use-after-free of net by tcp reqsk timer.
Date: Fri, 23 Feb 2024 09:24:46 -0800 [thread overview]
Message-ID: <20240223172448.94084-1-kuniyu@amazon.com> (raw)
syzkaller reported an warning of netns ref tracker for RDS TCP listener,
which commit 740ea3c4a0b2 ("tcp: Clean up kernel listener's reqsk in
inet_twsk_purge()") partially fixed.
This series reverts the partial fix on the TCP side and fixes the root
cause on the RDS side.
Kuniyuki Iwashima (2):
Revert "tcp: Clean up kernel listener's reqsk in inet_twsk_purge()"
rds: tcp: Fix use-after-free of net in reqsk_timer_handler().
net/ipv4/inet_timewait_sock.c | 15 +--------------
net/ipv4/tcp_minisocks.c | 9 ++++-----
net/rds/tcp_listen.c | 5 +++++
3 files changed, 10 insertions(+), 19 deletions(-)
--
2.30.2
next reply other threads:[~2024-02-23 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 17:24 Kuniyuki Iwashima [this message]
2024-02-23 17:24 ` [PATCH v1 net 1/2] Revert "tcp: Clean up kernel listener's reqsk in inet_twsk_purge()" Kuniyuki Iwashima
2024-02-23 17:24 ` [PATCH v1 net 2/2] rds: tcp: Fix use-after-free of net in reqsk_timer_handler() Kuniyuki Iwashima
2024-02-23 18:09 ` Eric Dumazet
2024-02-23 18:28 ` Kuniyuki Iwashima
2024-02-26 19:14 ` Kuniyuki Iwashima
2024-02-26 19:22 ` Allison Henderson
2024-02-26 19:38 ` Kuniyuki Iwashima
2024-02-26 19:52 ` Eric Dumazet
2024-02-26 20:00 ` Kuniyuki Iwashima
2024-02-26 19:40 ` Eric Dumazet
2024-02-26 19:48 ` Kuniyuki Iwashima
2024-02-26 20:00 ` Eric Dumazet
2024-02-26 20:05 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223172448.94084-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox