From: Jiri Benc <jbenc@redhat.com>
To: Richard Gobert <richardbgobert@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, idosch@nvidia.com, razor@blackwall.org,
amcohen@nvidia.com, petrm@nvidia.com, b.galvani@gmail.com,
bpoirier@nvidia.com, gavinl@nvidia.com, martin.lau@kernel.org,
daniel@iogearbox.net, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: geneve: enable local address bind for geneve sockets
Date: Sat, 24 Feb 2024 11:06:22 +0100 [thread overview]
Message-ID: <20240224110622.4855a202@griffin> (raw)
In-Reply-To: <79a8ba83-86bf-4c22-845c-8f285c2d1396@gmail.com>
On Thu, 22 Feb 2024 21:53:50 +0100, Richard Gobert wrote:
> static const struct nla_policy geneve_policy[IFLA_GENEVE_MAX + 1] = {
> - [IFLA_GENEVE_UNSPEC] = { .strict_start_type = IFLA_GENEVE_INNER_PROTO_INHERIT },
> + [IFLA_GENEVE_UNSPEC] = { .strict_start_type = IFLA_GENEVE_LOCAL6 },
The strict_start_type value should stay at
IFLA_GENEVE_INNER_PROTO_INHERIT. We don't want to relax the strict
checking for that attribute and we want strict checking for the newly
added IFLA_GENEVE_LOCAL.
See the documentation in include/net/netlink.h.
Jiri
next prev parent reply other threads:[~2024-02-24 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 20:48 [PATCH net-next 0/2] net: add local address bind support to vxlan and geneve Richard Gobert
2024-02-22 20:51 ` [PATCH net-next 1/2] net: vxlan: enable local address bind for vxlan sockets Richard Gobert
2024-02-23 17:49 ` kernel test robot
2024-02-24 5:58 ` kernel test robot
2024-02-22 20:53 ` [PATCH net-next 2/2] net: geneve: enable local address bind for geneve sockets Richard Gobert
2024-02-22 22:31 ` Eyal Birger
2024-02-27 9:02 ` Richard Gobert
2024-02-28 17:51 ` Eyal Birger
2024-02-24 9:01 ` kernel test robot
2024-02-24 10:06 ` Jiri Benc [this message]
2024-02-23 14:11 ` [PATCH net-next 0/2] net: add local address bind support to vxlan and geneve Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240224110622.4855a202@griffin \
--to=jbenc@redhat.com \
--cc=amcohen@nvidia.com \
--cc=b.galvani@gmail.com \
--cc=bpoirier@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gavinl@nvidia.com \
--cc=herbert@gondor.apana.org.au \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).