From: Jakub Kicinski <kuba@kernel.org>
To: wenyang.linux@foxmail.com
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Joel Granados <j.granados@samsung.com>,
Christian Brauner <brauner@kernel.org>,
davem@davemloft.net, David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] introduce sysctl SYSCTL_U8_MAX and SYSCTL_LONG_S32_MAX
Date: Mon, 26 Feb 2024 07:28:14 -0800 [thread overview]
Message-ID: <20240226072814.1d9ab85f@kernel.org> (raw)
In-Reply-To: <tencent_275FF7F351D515B570D0F82447BA30F3AA06@qq.com>
On Sun, 25 Feb 2024 12:05:30 +0800 wenyang.linux@foxmail.com wrote:
> The boundary check of multiple modules uses these static variables (such as
> two_five_five, n_65535, ue_int_max, etc), and they are also not changed.
> Therefore, add them to the shared sysctl_vals and sysctl_long_vals to avoid
> duplication. This also reduce the size a bit
You provide no data on how big the reduction is.
Eric's suggestion to encode the values directly in the table entry
sounds great, please invest your time in that, instead of half measures.
next prev parent reply other threads:[~2024-02-26 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240225040621eucas1p281f4ae53ecc8c0e1979fdc0c6b09643f@eucas1p2.samsung.com>
2024-02-25 4:05 ` [PATCH 0/8] introduce sysctl SYSCTL_U8_MAX and SYSCTL_LONG_S32_MAX wenyang.linux
2024-02-25 20:15 ` Joel Granados
2024-02-26 15:28 ` Jakub Kicinski [this message]
2024-02-28 12:30 ` Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226072814.1d9ab85f@kernel.org \
--to=kuba@kernel.org \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=j.granados@samsung.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wenyang.linux@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).