From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
marcin.szycik@intel.com, sridhar.samudrala@intel.com,
wojciech.drewek@intel.com, pmenzel@molgen.mpg.de,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Subject: Re: [iwl-next v2 1/2] ice: tc: check src_vsi in case of traffic from VF
Date: Mon, 26 Feb 2024 13:34:48 +0000 [thread overview]
Message-ID: <20240226133448.GD13129@kernel.org> (raw)
In-Reply-To: <20240222123956.2393-2-michal.swiatkowski@linux.intel.com>
On Thu, Feb 22, 2024 at 01:39:55PM +0100, Michal Swiatkowski wrote:
> In case of traffic going from the VF (so ingress for port representor)
> source VSI should be consider during packet classification. It is
> needed for hardware to not match packets from different ports with
> filters added on other port.
>
> It is only for "from VF" traffic, because other traffic direction
> doesn't have source VSI.
>
> Set correct ::src_vsi in rule_info to pass it to the hardware filter.
>
> For example this rule should drop only ipv4 packets from eth10, not from
> the others VF PRs. It is needed to check source VSI in this case.
> $tc filter add dev eth10 ingress protocol ip flower skip_sw action drop
>
> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Hi Michal,
Should this be treated as a fix: have a Fixes tag; be targeted at 'iwl'?
That notwithstanding, this look good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2024-02-26 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 12:39 [iwl-next v2 0/2] ice: extend tc flower offload Michal Swiatkowski
2024-02-22 12:39 ` [iwl-next v2 1/2] ice: tc: check src_vsi in case of traffic from VF Michal Swiatkowski
2024-02-26 13:34 ` Simon Horman [this message]
2024-03-14 10:59 ` Michal Swiatkowski
2024-03-08 7:39 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2024-02-22 12:39 ` [iwl-next v2 2/2] ice: tc: allow ip_proto matching Michal Swiatkowski
2024-02-26 13:33 ` Simon Horman
2024-03-08 7:40 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2024-03-14 11:03 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226133448.GD13129@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
--cc=marcin.szycik@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=sridhar.samudrala@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).