From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09C0C54FB1 for ; Tue, 27 Feb 2024 15:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709046043; cv=none; b=SwdWn7cVkTU89A/uMcNYZWKPVo8bSusrYCtCPyPtCoSf7NR709JdE5YdSvbpYvFULqQt95NydE24trAniWHhlme2SKvEfVYZmLqTiP8VAEbIpnfVzTFUrZ2K+f0v6JxrS4IZdlV+zJlG+QU1HRH7u9Qy7c3QcB3XvmgpT0g5frs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709046043; c=relaxed/simple; bh=ESSATTN5RBpJIcOmczuuNsJfKNsA1F0ttFhZPTp4i/M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tt9lLj43DqRTpxNZcr1Z90+PLqCE+dFNNALk70a7RNTWxiTWvnQ6WkWXgLLrLnS+F/FwBFJpWJS50a9/tCi80mP53tbRt5hns0XuS/AAaVKHEv9dJi76Gb88SmiqKFpzJML78xM50WCKjtsv5lgLi4WF5AmnnShCmL5PAsV1f1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cMamoNIq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cMamoNIq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F0A7C433C7; Tue, 27 Feb 2024 15:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709046042; bh=ESSATTN5RBpJIcOmczuuNsJfKNsA1F0ttFhZPTp4i/M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cMamoNIquaCDH+yOy3rvz466BZmUWyCto5lwPJqAa+ZeUymHeOMxP8TCRE6wvsMTa 623II65oi7dSirXdXGxDkeWVbAHALoIrjDV9GXzl97iF438hBVBswVjGj7TS+X9eX7 OrcGLBNEXp16gyKSkxwRnY99iBuI7hdn6vSWI1cv2689118wa+csC+WCzV/u+TFM2o weSHwNGkpd9Yzex8CFmU1Sz9zsqZ7WLtXEtBocyCUR2WKv5zzY+bswVjg1AjOeSyvQ KNerqhIRQ3l6/SHQa/Qe7Y/I7ls/Mpb4pUvnr8/7gy67Z92LjXAFgmPMUAaEYuxCP7 EYsczZ9qWhK2w== Date: Tue, 27 Feb 2024 07:00:41 -0800 From: Jakub Kicinski To: Przemek Kitszel Cc: , , , , , , , , , Subject: Re: [PATCH net-next 1/3] netdev: add per-queue statistics Message-ID: <20240227070041.3472952b@kernel.org> In-Reply-To: References: <20240226211015.1244807-1-kuba@kernel.org> <20240226211015.1244807-2-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 27 Feb 2024 11:29:02 +0100 Przemek Kitszel wrote: > > + * Device drivers are encouraged to reset the per-queue statistics when > > + * number of queues change. This is because the primary use case for > > + * per-queue statistics is currently to detect traffic imbalance. > > I get it, but encouraging users to reset those on queue-count-change > seems to cover that case too. I'm fine though :P What do you mean? Did I encourage the users somewhere?