* [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_get/seticmpfilter
@ 2024-02-27 0:57 Zhengchao Shao
2024-02-27 17:18 ` Simon Horman
2024-02-28 11:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Zhengchao Shao @ 2024-02-27 0:57 UTC (permalink / raw)
To: netdev, davem, dsahern, edumazet, kuba, pabeni
Cc: weiyongjun1, yuehaibing, shaozhengchao
The input parameter 'level' in rawv6_get/seticmpfilter is not used.
Therefore, remove it.
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
net/ipv6/raw.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 479c4c2c1785..76e6eb3b643d 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -934,7 +934,7 @@ static int rawv6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
goto done;
}
-static int rawv6_seticmpfilter(struct sock *sk, int level, int optname,
+static int rawv6_seticmpfilter(struct sock *sk, int optname,
sockptr_t optval, int optlen)
{
switch (optname) {
@@ -951,7 +951,7 @@ static int rawv6_seticmpfilter(struct sock *sk, int level, int optname,
return 0;
}
-static int rawv6_geticmpfilter(struct sock *sk, int level, int optname,
+static int rawv6_geticmpfilter(struct sock *sk, int optname,
char __user *optval, int __user *optlen)
{
int len;
@@ -1037,7 +1037,7 @@ static int rawv6_setsockopt(struct sock *sk, int level, int optname,
case SOL_ICMPV6:
if (inet_sk(sk)->inet_num != IPPROTO_ICMPV6)
return -EOPNOTSUPP;
- return rawv6_seticmpfilter(sk, level, optname, optval, optlen);
+ return rawv6_seticmpfilter(sk, optname, optval, optlen);
case SOL_IPV6:
if (optname == IPV6_CHECKSUM ||
optname == IPV6_HDRINCL)
@@ -1098,7 +1098,7 @@ static int rawv6_getsockopt(struct sock *sk, int level, int optname,
case SOL_ICMPV6:
if (inet_sk(sk)->inet_num != IPPROTO_ICMPV6)
return -EOPNOTSUPP;
- return rawv6_geticmpfilter(sk, level, optname, optval, optlen);
+ return rawv6_geticmpfilter(sk, optname, optval, optlen);
case SOL_IPV6:
if (optname == IPV6_CHECKSUM ||
optname == IPV6_HDRINCL)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_get/seticmpfilter
2024-02-27 0:57 [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_get/seticmpfilter Zhengchao Shao
@ 2024-02-27 17:18 ` Simon Horman
2024-02-28 11:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-02-27 17:18 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, davem, dsahern, edumazet, kuba, pabeni, weiyongjun1,
yuehaibing
On Tue, Feb 27, 2024 at 08:57:45AM +0800, Zhengchao Shao wrote:
> The input parameter 'level' in rawv6_get/seticmpfilter is not used.
> Therefore, remove it.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_get/seticmpfilter
2024-02-27 0:57 [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_get/seticmpfilter Zhengchao Shao
2024-02-27 17:18 ` Simon Horman
@ 2024-02-28 11:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-28 11:40 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, davem, dsahern, edumazet, kuba, pabeni, weiyongjun1,
yuehaibing
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 27 Feb 2024 08:57:45 +0800 you wrote:
> The input parameter 'level' in rawv6_get/seticmpfilter is not used.
> Therefore, remove it.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> net/ipv6/raw.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net-next] ipv6: raw: remove useless input parameter in rawv6_get/seticmpfilter
https://git.kernel.org/netdev/net-next/c/2e26b6dfade4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-28 11:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-27 0:57 [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_get/seticmpfilter Zhengchao Shao
2024-02-27 17:18 ` Simon Horman
2024-02-28 11:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).