From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318DE200A8; Wed, 28 Feb 2024 03:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709090859; cv=none; b=e1VtvUzfosd6d60OKhKY9/aRwP2ZhOH1EbJVMtwT7nl20QqzUWV06kiirUYmtlwDJJ19iLfJOzm+V6Un6Fy9eijfusnZiP2P4fNW7QFrbPasP/ZND2CA31G85Dd0B2ave9Cu4xzjRZkctOlNilXEbyu4nm0iyxqgstli+thTweQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709090859; c=relaxed/simple; bh=PxStEec/OucY88faF3IBr5N3T4pzL8MHzbg0huNkeQQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LngL6Un/NwScGnLxkQExdTMNBqDp6+9IvHf3AWv9h6wZAcX5IsUXG3/vUharvCen5EzbV942EYjTK2flTR//J4YxrCsWmm4h82ul9nbfYQ1w/n3An+jlUZmJ/ExTpEMMRTz5YBC30UJNUX1JEOsegf0/nCrRPzx5fyh99soMU5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QohiKP2o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QohiKP2o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7E73C433F1; Wed, 28 Feb 2024 03:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709090859; bh=PxStEec/OucY88faF3IBr5N3T4pzL8MHzbg0huNkeQQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QohiKP2oUlYmBY59Cy+RuyemEWPJDO5INyMmAP4cnWYa61MvqxzWbOWQ7QrkAr57U sPpg2I9PAiQzmbh9Iq3kC5nizezkGjbTn2K677Ci8RM0B5MPa5LEYDpDBWRFxVnOxv t7jm4Z8ZGZ+7HELUw5a+ri35666+dhnF4QEC7+ycodAEqtCR1ZpB3fnhllDmrQ6i2l uHWckA9X5pRSMuh0VJVv9cbl4bC/lavkenE0SYuieyYYFuJ1NZY904mEj7XJrk4rH4 bOKFA5biMK++N9Y3xLJ8aq/RBcyJ3REIsDT68i7DsaVrM2ojBxaEAnBQva3sVviBmb tr1pEEF3/gjYw== Date: Tue, 27 Feb 2024 19:27:37 -0800 From: Jakub Kicinski To: Kory Maincent Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu Subject: Re: [PATCH net-next v9 06/13] net: Add struct kernel_ethtool_ts_info Message-ID: <20240227192737.5d834155@kernel.org> In-Reply-To: <20240226-feature_ptp_netnext-v9-6-455611549f21@bootlin.com> References: <20240226-feature_ptp_netnext-v9-0-455611549f21@bootlin.com> <20240226-feature_ptp_netnext-v9-6-455611549f21@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 26 Feb 2024 14:39:57 +0100 Kory Maincent wrote: > In prevision to add new UAPI for hwtstamp we will be limited to the struct > ethtool_ts_info that is currently passed in fixed binary format through the > ETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new kernel code > already started operating on an extensible kernel variant of that > structure, similar in concept to struct kernel_hwtstamp_config vs struct > hwtstamp_config. > > Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, here > we introduce the kernel-only structure in include/linux/ethtool.h. > The manual copy is then made in the function called by ETHTOOL_GET_TS_INFO. This one doesn't apply. It's going to be a pain to keep rebasing it, since its a nop AFAICT - do you want to post it separately to get it merged quickly? -- pw-bot: cr