netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Mateusz Pacuszka <mateuszx.pacuszka@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Lukasz Plachno <lukasz.plachno@intel.com>,
	Jakub Buchocki <jakubx.buchocki@intel.com>,
	Pawel Kaminski <pawel.kaminski@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
	Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Pawel Chmielewski <pawel.chmielewski@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH iwl-net 0/5] ice: LLDP support for VFs
Date: Wed, 28 Feb 2024 08:47:45 -0800	[thread overview]
Message-ID: <20240228084745.2c0fef0e@kernel.org> (raw)
In-Reply-To: <20240228155957.408036-1-larysa.zaremba@intel.com>

On Wed, 28 Feb 2024 16:59:44 +0100 Larysa Zaremba wrote:
> Allow to:
> * receive LLDP packets on a VF
> * transmit LLDP from a VF
> 
> Only a single VF per port can transmit LLDP packets,
> all trusted VFs can transmit LLDP packets.
> 
> For both functionalities to work, private flag
> fw-lldp-agent must be off.
> 
> I am aware that implemented way of configuration (through sysfs) can be
> potentially controversial and would like some feedback from outside.

Why is the device not in switchdev mode? You can put your lldp-agent
priv flag on repr netdevs.

  parent reply	other threads:[~2024-02-28 16:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 15:59 [PATCH iwl-net 0/5] ice: LLDP support for VFs Larysa Zaremba
2024-02-28 15:59 ` [PATCH iwl-net 1/5] ice: Add function to get VF from device struct Larysa Zaremba
2024-02-28 15:59 ` [PATCH iwl-net 2/5] ice: Fix check for existing switch rule Larysa Zaremba
2024-02-28 15:59 ` [PATCH iwl-net 3/5] ice: Do not add LLDP-specific filter Larysa Zaremba
2024-02-28 15:59 ` [PATCH iwl-net 4/5] ice: Implement VF LLDP RX support on VF Larysa Zaremba
2024-02-29  9:12   ` Jiri Pirko
2024-02-28 15:59 ` [PATCH iwl-net 5/5] ice: Implement VF LLDP TX support for VF Larysa Zaremba
2024-02-28 16:47 ` Jakub Kicinski [this message]
2024-02-29  9:20   ` [PATCH iwl-net 0/5] ice: LLDP support for VFs Jiri Pirko
2024-02-29 15:28     ` Jakub Kicinski
2024-02-29 19:33       ` Larysa Zaremba
2024-03-01 17:08         ` Jakub Kicinski
2024-03-02  0:50           ` Larysa Zaremba
2024-03-05 19:54             ` Jakub Kicinski
2024-03-02  6:47               ` Larysa Zaremba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240228084745.2c0fef0e@kernel.org \
    --to=kuba@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jakubx.buchocki@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=larysa.zaremba@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.plachno@intel.com \
    --cc=mateusz.polchlopek@intel.com \
    --cc=mateuszx.pacuszka@intel.com \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pawel.chmielewski@intel.com \
    --cc=pawel.kaminski@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).