From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B9F86275; Thu, 29 Feb 2024 15:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709220495; cv=none; b=PoFUfGG8H5LQucI7UbUn7kRd1JpYgB+oPaCCAmmTKEvoQPFSzHsuHk5KnR9wpRrvzkw+QLUJxoYgBqF6aRazq1aJ7UjzmOzVFX9w5dWd1snn3+2IZxlelCfRblCUEmHjeBYRWuOL8BWPJrJTErDn7DbIHVZ8i0N97GFwTJTv504= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709220495; c=relaxed/simple; bh=mBQXZyrRxgzNUolzhgxjlsuqSS7+yHr2XWDMdZUoF8w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k0Z+aNOxyUFo3Df5xWuEazDCNAxTqI7umTsfgQ1n13UrCikc+Ilx5keSwGnVq0CWtZ9dRneupiKUG24qW59Nf3TvMMcFLC8rEzvwRTkWyW8UYmVKlKi+yeJK4UPOzbNTR/EyJ9vE5pVjPycOkK5OA1cJUyHUSUWwuWl7SJteT78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=thFtna3X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="thFtna3X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F2A4C433F1; Thu, 29 Feb 2024 15:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709220495; bh=mBQXZyrRxgzNUolzhgxjlsuqSS7+yHr2XWDMdZUoF8w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=thFtna3XIf74IR8tJBbuB5/fLJRn8cAoY8FRSZp73ZENJF23ybG9GkALI0fbnxSHL TlTNqyFiS/wWRH1GKf4Wx4nVitwEZ8gUAx7cyfZ9ViqQ33HSDZX9/uRch7fB3WVgAY wOcEzvnbucsi0EU+Rpu1jQ/YtlDdps1cmB38pQ3ILD+Bq5MdnJxGtzzFP11C44afAD ELBnWpinULqCORPnTdGK6rQsk8qoBVx98mONgIFfI0iWJ0qwWmHAwBngsS8P8Of3Cs u3h+453um7Kw43U/9RT3YxGeVITfmT/vf+EMEUlSRjJZELbqG0mrxSSKakeAOVECd0 sexdu9ZX7IYEw== Date: Thu, 29 Feb 2024 07:28:13 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: Larysa Zaremba , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mateusz Pacuszka , Tony Nguyen , Lukasz Plachno , Jakub Buchocki , Pawel Kaminski , Przemek Kitszel , Michal Swiatkowski , Mateusz Polchlopek , "David S. Miller" , Eric Dumazet , Paolo Abeni , Pawel Chmielewski , Jesse Brandeburg Subject: Re: [PATCH iwl-net 0/5] ice: LLDP support for VFs Message-ID: <20240229072813.5d7614c3@kernel.org> In-Reply-To: References: <20240228155957.408036-1-larysa.zaremba@intel.com> <20240228084745.2c0fef0e@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 29 Feb 2024 10:20:05 +0100 Jiri Pirko wrote: > But isn't it a matter of eswitch configuration? I mean, the user should > be free to configure filtering/forwarding of any packet, including LLDP > ones. This is an LLDP agent which runs as part of the NIC FW, AFAIU, not about forwarding or filtering. They already have the priv flag, so best to reuse that. If not possible we can explore options, but as Larysa mentioned herself in the cover letter sysfs is probably low on the preference list :(