From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D621160644 for ; Thu, 29 Feb 2024 20:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709237695; cv=none; b=EK+WWDOViAIaFkgvQm42WOcbN5mKx8LjdoiPIGJxzJkT4ZpIutrAIY+rJ7WZrXmc1vnKZ54VqHa81a5GIwKLfjL5zCnFnbBkRPHyMfg7GgZ1NBMtIGvuUEGzMjZ9KtCSkRPDLZZyghlH+SP2CJew3HSsvmgz0js5Fi82GHDO4w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709237695; c=relaxed/simple; bh=Wa3fEmcT8iASzXg5BDAQNlzrnTPnu1fep6ASZ72R8Bk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cWis3z4OYgJc0QXgbV5FO/SXLBqlj/UPtrgxxXFkQWELQ1Oj2/1VYxvUmTrPidpfGOX61pcdLpdsq+IIYyU9W5Ne6kwhtLc5f36jnfQl/fdu5ZrHdtvkkdI8U48VPajMlArLOBV1GLyxd0+aw85N5VRAaBSH5baIjWkM/uZdmoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=utUpHBFE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="utUpHBFE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B4EAC433C7; Thu, 29 Feb 2024 20:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709237694; bh=Wa3fEmcT8iASzXg5BDAQNlzrnTPnu1fep6ASZ72R8Bk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=utUpHBFE4kXqFnhtJzD/RYBaUlQycyz2+E2jxZmTFR9iyEitcXVbIep2B23c2wQJw ePReVvq6rk0xUv+qj0aGL0UUVsbAjAesknD/atsMuB1rcmZF5Z8+kWo98eSwSCT0mL /VmhnNxtati7gWptNjU3kFYGDvQJaA6lQKHn6kmGcYOhCF+p7yleWWDFYVQL3HMhqE YZfNhvZfTX22bR/KRi1WLH7CFj4Hr3lWBxjh8Vk9W7mg68U6/Tp05BQgms8m8MaiTG D9F0cMy0q7Pwv6Xmd69t1UCN+gxzcpvU78/7Tm3odtKlMfURskYcOmxcmtiLn7uasN 5c57jtRB2JzkQ== Date: Thu, 29 Feb 2024 12:14:52 -0800 From: Jakub Kicinski To: "Keller, Jacob E" Cc: Oleksij Rempel , Jiri Pirko , "Nguyen, Anthony L" , "davem@davemloft.net" , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" , "richardcochran@gmail.com" , "nathan.sullivan@ni.com" , "Pucha, HimasekharX Reddy" Subject: Re: [PATCH net] igb: extend PTP timestamp adjustments to i211 Message-ID: <20240229121452.2272d01c@kernel.org> In-Reply-To: References: <20240227184942.362710-1-anthony.l.nguyen@intel.com> <20240228202055.447485cb@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 29 Feb 2024 20:09:03 +0000 Keller, Jacob E wrote: > > On Wed, 28 Feb 2024 17:43:03 +0000 Keller, Jacob E wrote: =20 > > > Without this, the i211 doesn't apply the Tx/Rx latency adjustments, > > > so the timestamps would be less accurate than if the corrections are > > > applied. On the one hand I guess this is a "feature" and the lack of > > > a feature isn't a bug, so maybe its not viewed as a bug fix then. =20 > >=20 > > I tossed a coin and it said.... "whatever, man". Such sass, tsk tsk. =20 >=20 > I might have not had enough caffiene when writing that email... =F0=9F=98= =8A Sorry, my bad, I was barely awake. What I meant to convey is that it's borderline, so discussing how people feel is not a good use of anyone's time. It's a 3 LoC change to include one chip in what's done for another chip, it has been well tested, and has user impact. It's fine.