From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEA8F16FF5D for ; Thu, 29 Feb 2024 21:31:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709242307; cv=none; b=PVB9EpUMP2zdMOelk1nL0tSv1oc40ACmb+wL7qhye/Dask6ws+Vt++paa9roNRTVixtNR11E0r4p8nH/BGoV4w30xLrlEkVEwBFYYdue2IE2UeTFaIoVki1RbcAz4imcYnc9CCUVRMD6mzYk/Zv7CxeS20bQNk+tcZKUkNRxlNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709242307; c=relaxed/simple; bh=QzZTm6RzwKOCXz1s1DDgA6t36vWxFMgXU9qMOsdvjRM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TcWziGbA4gSHS/fqKT391YCelo712um/pgH4W/Rja3xV+/mvavzJe3AglY14PLlEOenBG3i+BN+bmdiiE5XKCWMngjPnx/HFVFGqVj4Ah5PaRoc56GnI1DJzP1WuVe7qPwFgL1PvHhLaDAYWVAeI/vtVYcOn94ls3a3tSdweVgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Otdgupdr; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Otdgupdr" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1dc49b00bdbso14678045ad.3 for ; Thu, 29 Feb 2024 13:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709242305; x=1709847105; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fi9gJh0JIT3rydMe7Re3YRcK5pxmffs/i/bQwJvpoAc=; b=OtdgupdrMqUU6v6YG5ItdSUVYWtggtW7CLi08MPwU/tGTaozH8afksz/j9WnraUdkZ gQO7+saJw0TruPFKJJShHIMwzH14EPnGlOS+T/kEWAOEPVR4l6UaIrHpoabCCEf3XPtP BuKQeG2cQ0ZPa/TIhRpwB3WIcITiVw6Bv0O6A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709242305; x=1709847105; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fi9gJh0JIT3rydMe7Re3YRcK5pxmffs/i/bQwJvpoAc=; b=xHimX3x8qHiOC8pcEtZ+75pamutmZSRI2wWaL7m1DO+AdImzyeXVq+6bVaRS580DQe nOPtwPLG3rRnsryQ+/XZVCb/wnD9xZmAhe/MqAjBCndWHWDBnfRWLjAo5fa7FrRPWItW 7uVXwIyXMyhgtVDRkH5Gt9C6zTOIDT2mv4MDWKSkfVP3+4ZEji4d+9o6qL0gKErZX2a7 rJrFBAHV+vAcJiJWTwDafIRc1lh4pxs92NxSsv+p0Daq8PKOshsQ7t+C/PFpyLaKWCup HTjJMZ4Yb5d+f/39Noj1JCwrXT3gXA3b7cQE2DrtyaaAJ0FfLCk75ESP9FIgkdN+XdQS 2mFA== X-Forwarded-Encrypted: i=1; AJvYcCU4F0XnkZmSeVPf0566aDls9WZ+eTTOVyOx6oLeaFS/JdoNwEPeObrL+IPtoTtijKGfiFXLOIlCN5aUBuvWvAWq0KAHVbu7 X-Gm-Message-State: AOJu0YzYZeApOg6M0KhbrPsfy2r/8F5YndCm/rIFiaUrziDPxA9pqwEH nhftcAUKqanm3DJhwxuL8CC+w2G8j4TM3OunAwQQ6nT43jpsC/1bNMVfgQuQZw== X-Google-Smtp-Source: AGHT+IE+DUv8Qdh0LZ32jo8m9iF3a01wivEsDDN/MHriPt719iWzbKIbR1Qbd56MoYjYqe7Ub9Claw== X-Received: by 2002:a17:902:654a:b0:1dc:ca72:8318 with SMTP id d10-20020a170902654a00b001dcca728318mr2807886pln.37.1709242304905; Thu, 29 Feb 2024 13:31:44 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id y9-20020a1709027c8900b001db717d2dbbsm1954387pll.210.2024.02.29.13.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:31:44 -0800 (PST) Date: Thu, 29 Feb 2024 13:31:43 -0800 From: Kees Cook To: Jakub Kicinski Cc: Andy Shevchenko , Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 7/8] net-device: Use new helpers from overflow.h in netdevice APIs Message-ID: <202402291330.0510946B67@keescook> References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-8-andriy.shevchenko@linux.intel.com> <202402281341.AC67EB6E35@keescook> <20240228144148.5c227487@kernel.org> <202402281554.C1CEEF744@keescook> <20240228165609.06f5254a@kernel.org> <202402291059.491B5E03@keescook> <20240229113706.42c877a1@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240229113706.42c877a1@kernel.org> On Thu, Feb 29, 2024 at 11:37:06AM -0800, Jakub Kicinski wrote: > On Thu, 29 Feb 2024 11:08:58 -0800 Kees Cook wrote: > > > And some seem to be cargo-culted from out-of-tree code and are unused :S > > > > Ah, which can I remove? > > The one in igc.h does not seem to be referenced by anything in the igc > directory. Pretty sure it's unused. I'll double check. After trying to do a few conversions I really hit stuff I didn't like, so I took a slightly different approach in the patch I sent. -- Kees Cook