From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 484751FA1; Fri, 1 Mar 2024 14:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303876; cv=none; b=VXJW1sLvHCXIdKt+hylyWboOTdQz1NhWFXczWvsbMpTSOMrSPLhV43oaH+80ItWJCzHkQc5PqPFvLMjyQ6AXv71gxcqfWxm9I+pwzc5Z0bmiqUsltU7iCarne6Lb6QwJ2s6MQ4RicYxvtsyDttJdjq5inBZZ3X3atWpVP8D+0/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303876; c=relaxed/simple; bh=2r1Wp3rYCpQCXBRXRGrQRKnkowj3xl49dA+H2NJnMBU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FsLOdZJnR0DV8Qve736fQ5+A0a6YjzsgbW0lMYHFdmFo8EqzqABdcPjgUst+jTKh6QWoPgIvVFgi0wrpAor2x6mbZt7trGSQ8Y0a7/jgC8CmcB3ur6oNYKxLgSkDDhbTajXOFQ0TnGI3n0hnFsarBhn8Ubs5k/gVxnQIJBMr0+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jLcMwXej; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jLcMwXej" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4500FC433F1; Fri, 1 Mar 2024 14:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709303875; bh=2r1Wp3rYCpQCXBRXRGrQRKnkowj3xl49dA+H2NJnMBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jLcMwXejD/CL3+8qjIs5Xj3U6dmo915+bS91i0UNfhbY253V+tu4oVODlVblYPfIK kBbJyaJFzSnPbMfHsBljKPLYaDqhB5LDPn9cjmmFucHfOs97juG4NLacHkyaeXJFnq KRzG2NgL8sxQCK8gpLrl56up+kw9N55G/Tw7S1zvNyQomdVACQLEaeAahE2nupVWHp Yt/4BL5t28vLoTWaClOc+rBGN1zQqc0b29ciA5scV8eXufEMsPJvjdKioJRV4fyHew 6XY8fr7/coD3tETytB8GrViKeA/CBmmcZ5a0/ZuEjsCBnL3FrneePy4UPD8aV11hWZ Yb523th9q7o6Q== Date: Fri, 1 Mar 2024 06:37:54 -0800 From: Jakub Kicinski To: "Matthieu Baerts (NGI0)" , Mat Martineau , Paolo Abeni Cc: mptcp@lists.linux.dev, Geliang Tang , "David S. Miller" , Eric Dumazet , Florian Westphal , Kishen Maloor , Shuah Khan , Peter Krystad , Christoph Paasch , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net 10/10] selftests: mptcp: explicitly trigger the listener diag code-path Message-ID: <20240301063754.2ecefecf@kernel.org> In-Reply-To: <20240223-upstream-net-20240223-misc-fixes-v1-10-162e87e48497@kernel.org> References: <20240223-upstream-net-20240223-misc-fixes-v1-0-162e87e48497@kernel.org> <20240223-upstream-net-20240223-misc-fixes-v1-10-162e87e48497@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 23 Feb 2024 17:14:20 +0100 Matthieu Baerts (NGI0) wrote: > From: Paolo Abeni > > The mptcp diag interface already experienced a few locking bugs > that lockdep and appropriate coverage have detected in advance. > > Let's add a test-case triggering the relevant code path, to prevent > similar issues in the future. > > Be careful to cope with very slow environments. > > Note that we don't need an explicit timeout on the mptcp_connect > subprocess to cope with eventual bug/hang-up as the final cleanup > terminating the child processes will take care of that. Hi! There's a failure in CI under debug after merging net and net-next in diag.sh. Maybe because of the patch which lowered timeout? https://lore.kernel.org/all/20240223-upstream-net-next-20240223-misc-improvements-v1-8-b6c8a10396bd@kernel.org/