* [PATCH net-next] eth: igc: remove unused embedded struct net_device
@ 2024-03-01 7:02 Jakub Kicinski
2024-03-01 7:59 ` Eric Dumazet
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jakub Kicinski @ 2024-03-01 7:02 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, intel-wired-lan, Jakub Kicinski,
jesse.brandeburg, anthony.l.nguyen
struct net_device poll_dev in struct igc_q_vector was added
in one of the initial commits, but never used.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: jesse.brandeburg@intel.com
CC: anthony.l.nguyen@intel.com
---
drivers/net/ethernet/intel/igc/igc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
index cfa6baccec55..90316dc58630 100644
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -570,7 +570,6 @@ struct igc_q_vector {
struct rcu_head rcu; /* to avoid race with update stats on free */
char name[IFNAMSIZ + 9];
- struct net_device poll_dev;
/* for dynamic allocation of rings associated with this q_vector */
struct igc_ring ring[] ____cacheline_internodealigned_in_smp;
--
2.43.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] eth: igc: remove unused embedded struct net_device
2024-03-01 7:02 [PATCH net-next] eth: igc: remove unused embedded struct net_device Jakub Kicinski
@ 2024-03-01 7:59 ` Eric Dumazet
2024-03-01 16:54 ` Jesse Brandeburg
2024-03-04 10:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2024-03-01 7:59 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, pabeni, intel-wired-lan, jesse.brandeburg,
anthony.l.nguyen
On Fri, Mar 1, 2024 at 8:03 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> struct net_device poll_dev in struct igc_q_vector was added
> in one of the initial commits, but never used.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] eth: igc: remove unused embedded struct net_device
2024-03-01 7:02 [PATCH net-next] eth: igc: remove unused embedded struct net_device Jakub Kicinski
2024-03-01 7:59 ` Eric Dumazet
@ 2024-03-01 16:54 ` Jesse Brandeburg
2024-03-04 10:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jesse Brandeburg @ 2024-03-01 16:54 UTC (permalink / raw)
To: Jakub Kicinski, davem
Cc: netdev, edumazet, pabeni, intel-wired-lan, anthony.l.nguyen
On 2/29/2024 11:02 PM, Jakub Kicinski wrote:
> struct net_device poll_dev in struct igc_q_vector was added
> in one of the initial commits, but never used.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Thanks Jakub, you can just apply this directly AFAICS.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] eth: igc: remove unused embedded struct net_device
2024-03-01 7:02 [PATCH net-next] eth: igc: remove unused embedded struct net_device Jakub Kicinski
2024-03-01 7:59 ` Eric Dumazet
2024-03-01 16:54 ` Jesse Brandeburg
@ 2024-03-04 10:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-04 10:10 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, intel-wired-lan,
jesse.brandeburg, anthony.l.nguyen
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 29 Feb 2024 23:02:55 -0800 you wrote:
> struct net_device poll_dev in struct igc_q_vector was added
> in one of the initial commits, but never used.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: jesse.brandeburg@intel.com
> CC: anthony.l.nguyen@intel.com
>
> [...]
Here is the summary with links:
- [net-next] eth: igc: remove unused embedded struct net_device
https://git.kernel.org/netdev/net-next/c/c2a22688c931
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-04 10:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-01 7:02 [PATCH net-next] eth: igc: remove unused embedded struct net_device Jakub Kicinski
2024-03-01 7:59 ` Eric Dumazet
2024-03-01 16:54 ` Jesse Brandeburg
2024-03-04 10:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).